Summary:	ASTERISK-02028: [patch] app_voicemail is unable to update config in res_config_odbc
Reporter:	pfn (pfn)	Labels:
Date Opened:	2004-07-15 17:21:47	Date Closed:	2011-06-07 14:04:49
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) voicemail_odbc.diff
Description:	When voicemail.conf is loaded into an ODBC database a voicemail user is unable to seamlessly change their PIN.  Currently an external hack is required to update the database. Included is a patch that modifies both app_voicemail and res_config_odbc, allowing a more seamless integration of of voicemail and ODBC config. ****** ADDITIONAL INFORMATION ****** This patch does not take into consideration any potential #include directives, however, it appears that app_voicemail, normally, does not take them into account as well.
Comments:	By: Mark Spencer (markster) 2004-07-16 00:04:59 This patch is too intrusive to really consider.  What if, instead of editing the config files, we just left  them alone and overrode the password in the astdb, and then so long as the password in the config file didn't change, we used the mapped one? By: Brian West (bkw918) 2004-07-16 11:47:30 thats such a hack.. I have a better solution.. externpasscmd = /path/to/someprog bkw By: pfn (pfn) 2004-07-16 11:51:10 Sorry, I don't understand, how is this patch too intrusive?  It only modifies app_voicemail and res_config_odbc, and the changes there are mostly isolated additional code.  No additional action needs to be done on part of the user to enable PIN changing when using both res_config and voicemail. As for not editing the config file, we're talking about ODBC here, an actual config file should not be involved, and storing the password both in an ODBC datasource and Asterisk's internal DB is confusing and a hack. edited on: 07-16-04 11:39 By: Tilghman Lesher (tilghman) 2004-07-16 12:57:42 As this is a password, we probably shouldn't be storing it in plaintext anywhere.  I had a patch that has long since fallen by the wayside that stores passwords in the ast database, in an MD5 hash.  Perhaps the password field in voicemail.conf needs be abandoned (i.e. left for backwards compatibility, but unused if another password exists in hashed format in the astdb). Mark:  if I were to revise that old patch, would that be an acceptable solution for voicemail passwords? By: twisted (twisted) 2004-07-23 21:01:27 Is this ready for cvs yet? By: Mark Spencer (markster) 2004-07-23 23:19:44 It would have to still be linked to the password listed in voicemail.conf, such that if someone changes the password in voicemail.conf, it overrides the astdb setting. this can be done by storing "oldpass:newpass" in /voicemail/passwords/context/mailbox in the database.