[Home]

Summary:ASTERISK-02027: [post-1.0][patch] Sending HTML voicemail messages
Reporter:constfilin (constfilin)Labels:
Date Opened:2004-07-15 16:06:42Date Closed:2004-09-25 02:04:40
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk_app_voicemail.patch
( 1) asterisk_app_voicemail.patch
( 2) asterisk_app_voicemail.patch
( 3) asterisk_app_voicemail.patch
( 4) asterisk-addons_mysql-vm-routines.patch
( 5) postgres-vm-routines.h
Description:There are scenarios when you want to send voicemail notifications in HTML format. Also there are scenarios when you want to send them both in text and HTML format so that the E-mail clients that can display HTML will display it. Those that cannot we default to text alternative.

The attached patch implements this functionality. The necessary change in configuration is "emailhtmlbody".

If you do not want to compiter HTML support, then set SUPPORT_EMAILHTMLBODY to 0 at the beginning of the file.

Also the patch contains changes described in patch ASTERISK-1791828.

The pactch with synced with the latest (1pm PST 7/15/2004) app_voicemail.c changes in CVS.


****** ADDITIONAL INFORMATION ******

I have already faxed disclaimer to Digium. It would be great to see this in CVS. The changes are backwards compatible.
Comments:By: Olle Johansson (oej) 2004-07-15 16:11:08

Please read the instructions on the front page... You need to add a "cvs diff -u" output of the changes to app_voicemail.c to this bug report.

Thank you for contributing to Asterisk!

/O
By: constfilin (constfilin) 2004-07-15 16:18:10

I ran cvs diff -u asterisk/apps/app_voicemail.c and attached the latest patch.
Thanks!
By: Tilghman Lesher (tilghman) 2004-07-15 17:10:32

I really think this should be a runtime option, instead of a compile time option.  Is there any reason that you think this patch couldn't be modified to do that?
By: constfilin (constfilin) 2004-07-15 18:10:05

Actually this is configuration time option. If yo do not want HTML email to be sent, then simply remove "emailhtmlbody" from voicemail.conf.

You can also completely turn this off in compile time by setting
#define SUPPORT_EMAILHTNLBODY to 0.

Or did you mean that emailhtmlbody should be taken from options of vmusers?

Thanks

-c
By: Mark Spencer (markster) 2004-07-15 20:51:34

This also seems to delete a bunch of the postgresvm stuff, was that intentional?
By: constfilin (constfilin) 2004-07-15 21:12:01

Actually it does not delete postgresvm stuff. It includes it from asterisk-addons/postgres-vm_routes.h file.

asterisk-addons/postgres-vm_routes.h is uploaded with patch ASTERISK-1791828

respectfully

Constantine

edited on: 07-15-04 20:56
By: Brian West (bkw918) 2004-07-16 22:15:49

Update to latest cvs and get new patch... ASAP
By: constfilin (constfilin) 2004-07-17 02:29:51

I uploaded the results of the commands

cvs diff -u asterisk/apps/app_voicemail.c
cvs diff -u asterisk-addons/mysql-vm-routines.c
Also I attached file asterisk-addons/postgres-vm-routines.c
By: constfilin (constfilin) 2004-07-21 20:07:21

I carefully synced CVS content with my changes and uploaded the latest patch that contains only important changes. All changes in the whitespace were eliminated. The patch also includes changes for bug ASTERISK-1791828.

Thanks!

edited on: 07-21-04 19:52
By: Mark Spencer (markster) 2004-09-13 18:16:35

Moved/merged