[Home]

Summary:ASTERISK-02012: [patches][src-audit] directories: astman, cdr, db1-ast, editline, pbx, res, and stdtime
Reporter:Rob Gagnon (rgagnon)Labels:
Date Opened:2004-07-14 04:14:34Date Closed:2004-09-25 02:26:24
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) astman.c.patch.txt
( 1) audit.patch.txt
( 2) cdr_csv.c.patch.txt
( 3) cdr_odbc.c.patch.txt
( 4) cdr_pgsql.c.patch.txt
( 5) cdr_sqlite.c.patch.txt
( 6) common.c.patch.txt
( 7) hist.c.patch.txt
( 8) localtime.c.patch.txt
( 9) ndbm.c.patch.txt
(10) pbx_gtkconsole.c.patch.txt
(11) pbx_spool.c.patch.txt
(12) pbx_wilcalu.c.patch.txt
(13) res_adsi.c.patch.txt
(14) res_adsi.c.patch.txt
(15) res_config_odbc.c.patch.txt
(16) res_crypto.c.patch.txt
(17) res_indications.c.patch.txt
(18) res_musiconhold.c.patch.txt
(19) res_odbc.c.patch.txt
(20) res_osp.c.patch.txt
Description:19 patches along same lines as others

****** ADDITIONAL INFORMATION ******

[disclaimed]

NOTE the change is the res_adsi.c patch file.  The init_state() function had four lines to setup the char array intro[] with Asterisk specific text, but it was followed by a loop immediately setting the same strings to "".

Please verify that removing the setting to "" is the intended effect.
Comments:By: Rob Gagnon (rgagnon) 2004-07-14 04:20:31

I'm an idiot...

Forget the comment above about res_adsi.c, and the intro[] array,  I for some reason saw "for(x=0;..." in my head when it says "for(x=3;..."
By: Rob Gagnon (rgagnon) 2004-07-14 04:23:21

The correct res_adsi patch is:

res_adsi.c.patch.txt (1,628 bytes) 07-14-04 04:22
By: Mark Spencer (markster) 2004-07-14 06:50:42

Can you just package these into a single patch?
By: Rob Gagnon (rgagnon) 2004-07-14 08:17:40

Sure.  I thought it was working out better this way, as then it would be easier to skip a file if one were deemed not needed.
By: Mark Spencer (markster) 2004-07-14 08:20:37

That was certainly a reasonable assumption, but it turns out that it's about as easy for me to just look at the one patch and "send it back" if there are any issues, but with the exception of the one snprintf misunderstanding, your work has obviously been very accurate.
By: Rob Gagnon (rgagnon) 2004-07-14 08:29:35

big file audit.patch.txt contains all the changes in the 19 other files.

Also, it picked up on changes to dlfcn.c, which would have been in one of the other patch bundles..

Not sure if it was meant to be skipped, but just want to let you know.
By: Rob Gagnon (rgagnon) 2004-07-14 08:33:03

also, thanks for the accuracy note...

and... do you ever sleep?  (just noting times on notes and commits :-)
By: Mark Spencer (markster) 2004-07-14 08:33:57

Can you explain the size_t transition?
By: Mark Spencer (markster) 2004-07-14 08:34:31

I have not been to sleep yet in the past 24 hours, no. heh
By: Rob Gagnon (rgagnon) 2004-07-14 08:37:31

where a (char *) is passed, and followed by an (int) for the size of the (char *), it seems more standard for the type to be defined as size_t in any man page... ie: snprintf() etc.

Just decided at some point to notice that, and start putting that into the asterisk code.
By: Mark Spencer (markster) 2004-07-14 11:07:24

Okay, all merged in save the last one.