[Home]

Summary:ASTERISK-02011: [patches][src-audit] apps directory files app_q*.c through app_z*.c
Reporter:Rob Gagnon (rgagnon)Labels:
Date Opened:2004-07-13 18:37:07Date Closed:2008-01-15 15:02:23.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_qcall.c.patch.txt
( 1) app_queue.c.patch.txt
( 2) app_record.c.patch.txt
( 3) app_rpt.c.patch.txt
( 4) app_rpt.c.patch.txt
( 5) app_setcidname.c.patch.txt
( 6) app_setcidnum.c.patch.txt
( 7) app_sms.c.patch.txt
( 8) app_sql_postgres.c.patch.txt
( 9) app_striplsd.c.patch.txt
(10) app_substring.c.patch.txt
(11) app_txtcidname.c.patch.txt
(12) app_voicemail.c.patch.txt
(13) app_zapbarge.c.patch.txt
(14) app_zapscan.c.patch.txt
Description:change strcat, strcpy, sprintf to strncat, strncpy, and snprintf as appropriate



****** ADDITIONAL INFORMATION ******

[disclaimed]
Comments:By: Tilghman Lesher (tilghman) 2004-07-13 21:18:51

StripLSD and Substring are both deprecated applications.  Instead of patching them, we should simply remove them from CVS.
By: Rob Gagnon (rgagnon) 2004-07-14 03:08:53

app_rpt.c.patch.txt changed to match CVS v1.16 of app_rpt.c

correct file is described: (7,966 bytes) 07-14-04 03:08
By: Mark Spencer (markster) 2004-07-14 03:50:23

Merged them all in.  I'm just going to trust that your whitespace changes to app_sms didn't break anything -- it's a bit hard to read.  My reading of you striplsd changes is that it changes its behavior, but your version seems to be more logical anyway.
By: Rob Gagnon (rgagnon) 2004-07-14 04:00:26

Yea, sorry about breaking the "don't reformat for fun" rule, but the function was a bit tough to follow with the spacing as it was.

in striplsd, I needed a variable to use in the strncpy() function, so that's why that changed.

Also, normally would not re-open, but app_setcidname.c.patch.txt did not get merged--- It's a one-liner
By: Mark Spencer (markster) 2004-07-14 04:03:10

Got it sorry.
By: Digium Subversion (svnbot) 2008-01-15 15:02:22.000-0600

Repository: asterisk
Revision: 3429

U   trunk/apps/app_qcall.c
U   trunk/apps/app_queue.c
U   trunk/apps/app_record.c
U   trunk/apps/app_rpt.c
U   trunk/apps/app_setcidnum.c
U   trunk/apps/app_sms.c
U   trunk/apps/app_sql_postgres.c
U   trunk/apps/app_striplsd.c
U   trunk/apps/app_substring.c
U   trunk/apps/app_txtcidname.c
U   trunk/apps/app_voicemail.c
U   trunk/apps/app_zapbarge.c
U   trunk/apps/app_zapscan.c

------------------------------------------------------------------------
r3429 | markster | 2008-01-15 15:02:21 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge rgagnon's pedantic string changes (apps n-z) (bug ASTERISK-2011)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=3429
By: Digium Subversion (svnbot) 2008-01-15 15:02:23.000-0600

Repository: asterisk
Revision: 3431

U   trunk/apps/app_setcidname.c

------------------------------------------------------------------------
r3431 | markster | 2008-01-15 15:02:23 -0600 (Tue, 15 Jan 2008) | 2 lines

Oops forgot one (bug ASTERISK-2011)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=3431