Summary: | ASTERISK-01971: [patch] app_voicemail.c patch in #1971 undid part of #1977 | ||
Reporter: | Rob Gagnon (rgagnon) | Labels: | |
Date Opened: | 2004-07-08 11:02:27 | Date Closed: | 2008-01-15 15:01:56.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) app_voicemail.c.patch.txt | |
Description: | The run_externnotify() function reverted back to bad code with the latest app_voicemail.c patch. Patch attached fixes it again. ****** ADDITIONAL INFORMATION ****** The strncpy() in the function is not needed as it is followed by a snprintf() to the same variable. Also, the snprintf() does not need -1 in the size_t spot, and function uses ast_strlen_zero() to check the string to be uniform with other code. [disclaimed] | ||
Comments: | By: Mark Spencer (markster) 2004-07-08 11:18:00 Fixed in CVS By: Digium Subversion (svnbot) 2008-01-15 15:01:56.000-0600 Repository: asterisk Revision: 3398 U trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r3398 | markster | 2008-01-15 15:01:56 -0600 (Tue, 15 Jan 2008) | 2 lines Re-fix bug ASTERISK-1952 (bug ASTERISK-1971) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3398 |