Summary: | ASTERISK-01970: Get the correct expire-time from REGISTER response | ||
Reporter: | nogren (nogren) | Labels: | |
Date Opened: | 2004-07-08 10:09:28 | Date Closed: | 2008-01-15 15:02:09.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) sipreg.txt | |
Description: | When the SIP registrar, accordlingly to the RFC, replies with all contacts for current user, Asterisk picks the first expire-time, not the one for his register contact, and sets the scheduler to re-register on the wrong time. Results in asterisk not being registered in the registry in case of another contact with longer expire-time. ****** ADDITIONAL INFORMATION ****** Patch uploaded, which also adds the ability to see the last chosen expiretime with "sip show registry", instead of the refresh-time. | ||
Comments: | By: Mark Spencer (markster) 2004-07-08 10:34:11 You already have a diiiiiiisclaimer on file right? By: Mark Spencer (markster) 2004-07-08 10:39:16 is the refresh line the only one that's really relevent here? I don't see what hte first one does. By: nogren (nogren) 2004-07-08 11:21:09 Yes, I have a disclaimer. The first hunk is the importand one. It moves the pointer contact forward in the contact-header, that is a comma-separated list of contacts registered at the register-server, to the one that is asterisk's, and use that expire-time instead of the first. By: Mark Spencer (markster) 2004-07-09 07:18:07 Fixed in CVS, thanks for the patch! By: Digium Subversion (svnbot) 2008-01-15 15:02:09.000-0600 Repository: asterisk Revision: 3413 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r3413 | markster | 2008-01-15 15:02:08 -0600 (Tue, 15 Jan 2008) | 2 lines Expire time fix (bug ASTERISK-1970) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3413 |