[Home]

Summary:ASTERISK-01936: crackle and high-pitched squeal for call waiting
Reporter:tomscotto (tomscotto)Labels:
Date Opened:2004-07-01 11:04:07Date Closed:2011-06-07 14:10:46
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:crackle and high-pitched squeal occurs for call waiting for both the sender and receiver of the call.  this occurs only once initially when the first tonal is generated indicating to the caller that the person is on the phone and that another call is coming in to the person that is currently on the phone.

****** ADDITIONAL INFORMATION ******

in file/function chan_zap.c/zt_callwait:

               save_conference(p);
               /* Setting line silence removed from here by T.O. to fix squeal on call waiting
               memset(p->cidspill, 0x7f, 2400 + 600 + READ_SIZE * 4); */
               if (!p->callwaitrings && p->callwaitingcallerid) {
                       /* silence setting - moved here by T.O. */
                       memset(p->cidspill, 0x7f, 2400 + 680 + READ_SIZE * 4);
                       ast_gen_cas(p->cidspill, 1, 2400 + 680, AST_LAW(p));
                       p->callwaitcas = 1;
                       p->cidlen = 2400 + 680 + READ_SIZE * 4;
               } else {
                       /* silence setting - moved here by T.O. */
                       memset(p->cidspill, 0x7f, 2400 + READ_SIZE * 4);
                       ast_gen_cas(p->cidspill, 1, 2400, AST_LAW(p));
                       p->callwaitcas = 0;
                       p->cidlen = 2400 + READ_SIZE * 4;
               }
               p->cidpos = 0;
               send_callerid(p);


and in file/function callerid.c/ast_gen_cas      

/* buffer too small - created squeal when call waiting - fixed by T.O.
       int saslen=2400; */
       int saslen=3080;
       float cr1 = 1.0;
       float ci1 = 0.0;
       float cr2 = 1.0;
       float ci2 = 0.0;
       if (sendsas) {
/*
       don't worry about this - T.O.
               if (len < saslen)
                       return -1;
*/


Comments:By: Olle Johansson (oej) 2004-07-01 11:53:19

Sorry, but is the code a fix to the problem you have? If so, please attach a "cvs diff -u" output as a file to the bug report. If I misunderstand, please help me by explaining if you have a fix or if this is still a problem for you.

By: Mark Spencer (markster) 2004-07-01 18:23:24

The lengths of times are fixed.  You cant' change them.  If you don't like the "squeal" the either turn off callerid call waiting or tell bell to rewrite their spec not to require that tone.