Summary:	ASTERISK-01932: [patch] Stop app_voicemail.c from sending email if no email defined for user
Reporter:	Rob Gagnon (rgagnon)	Labels:
Date Opened:	2004-06-30 13:31:16	Date Closed:	2008-01-15 15:01:31.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail.c.patch.txt ( 1) app_voicemail.c.patch.txt
Description:	Currently, if you leave the email address for a user blank in voicemail.conf, or have an invalid email address, app_voicemail will still attempt to send an email. This of course, results in returned emails from the email server. ****** ADDITIONAL INFORMATION ****** Patch adds a check to make sure that at least a single at-sign (@) exists in the vmu->email string before continuing.  If the @-sign is missing, a LOG_WARNING message is printed and the function exits.
Comments:	By: Malcolm Davenport (mdavenport) 2004-06-30 14:04:00 Fixed in CVS.  Thank you! By: James Golovich (jamesgolovich) 2004-06-30 14:08:13 Email addresses don't require an @ sign in them.  I've seen many asterisk voicemail systems setup that use a local alias to handle the ultimate delivery, so the address did not have a @ in those cases By: Rob Gagnon (rgagnon) 2004-06-30 14:25:00 james... Thanks.  I am so used to the "normal" email addresses in my config, that I forgot about local ones. New patch uploaded. 771 bytes long to patch the patch edited on: 06-30-04 14:13 By: Malcolm Davenport (mdavenport) 2004-06-30 14:25:21 Good point. By: Rob Gagnon (rgagnon) 2004-06-30 14:29:43 Reminder sent to malcolmd I patched the patch against the updated CVS.  This time it looks for empty email address instead of missing "@" By: Malcolm Davenport (mdavenport) 2004-06-30 14:45:05 Done :D By: Digium Subversion (svnbot) 2008-01-15 15:01:31.000-0600 Repository: asterisk Revision: 3367 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r3367 | malcolmd | 2008-01-15 15:01:31 -0600 (Tue, 15 Jan 2008) | 2 lines Bug ASTERISK-1932.  Take two ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3367