Summary:	ASTERISK-01862: [patch] app_directory does nothing if last matching extension is skipped by user and last entry is last extension
Reporter:	Rob Gagnon (rgagnon)	Labels:
Date Opened:	2004-06-21 17:02:21	Date Closed:	2008-01-15 15:00:58.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_directory
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_directory.c.patch.txt ( 1) app_directory.c.patch.txt ( 2) app_directory.c.patch.txt
Description:	If last configured extension in a context is played to the user because it matched the 3 character input, and the user presses '*' to skip that entry...  app_directory exits with no notification to the user. The user gets the idea that the system has hung ****** ADDITIONAL INFORMATION ****** Patch resolves this issue and also cleans up the following: - removes a 'goto' from do_directory() function. - makes the playing of the mailbox identification into a subroutine (play_mailbox_owner() function)  This makes the do_directory() function a lot more manageable.
Comments:	By: Rob Gagnon (rgagnon) 2004-06-21 17:06:56 oops... left some debugging log msgs in original patch.  Please use the file dated 06-21-04 17:06 that is 6,420 bytes By: Rob Gagnon (rgagnon) 2004-06-21 19:03:03 I would consider this more than a tweak.  It is a real bug.  Functionality to have asterisk play the "dir-nomore" sound file does not exist without this patch under this situation. By: Rob Gagnon (rgagnon) 2004-06-21 19:05:44 and... crud.. I did it again... In my haste to remove an ast_log() message from the previously uploaded file, I missed one line, and forgot to re-compile.  Sorry about that The correct file is actually the 06-21-04 19:04 (6391 bytes) file (been a long day) edited on: 06-21-04 22:53 By: Mark Spencer (markster) 2004-06-21 19:25:44 Also, can you please confirm this has already been disclaimed? By: Rob Gagnon (rgagnon) 2004-06-21 23:08:59 Yes.  I should know that by now, with the number of patches I've submitted already, I always forget to mention I sent in the Disclaimer some time ago. By: Mark Spencer (markster) 2004-06-21 23:57:55 Fixed in CVS, thanks! By: Rob Gagnon (rgagnon) 2004-06-28 10:41:40 After more extensive testing, I found a situation where you could hang asterisk inside the directory. If user hangs up during list of names being played back, system will go into endless loop. Latest patch uploaded ((1,715 bytes) 06-28-04 10:42 ) stops this situation, as well as limits number of bad attempts to select each name to 3 times each. edited on: 06-28-04 10:27 By: Mark Spencer (markster) 2004-06-28 11:22:49 Fixed (again) in CVS. By: Digium Subversion (svnbot) 2008-01-15 15:00:03.000-0600 Repository: asterisk Revision: 3267 U   trunk/apps/app_directory.c ------------------------------------------------------------------------ r3267 | markster | 2008-01-15 15:00:03 -0600 (Tue, 15 Jan 2008) | 2 lines Directory fixes courtesy rgagnon (bug ASTERISK-1862) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3267 By: Digium Subversion (svnbot) 2008-01-15 15:00:58.000-0600 Repository: asterisk Revision: 3329 U   trunk/apps/app_directory.c ------------------------------------------------------------------------ r3329 | markster | 2008-01-15 15:00:58 -0600 (Tue, 15 Jan 2008) | 2 lines Directory fixes (bug ASTERISK-1862) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3329