[Home]

Summary:ASTERISK-01856: Quoted expressions in extension logic broken again
Reporter:thansen (thansen)Labels:
Date Opened:2004-06-21 03:55:48Date Closed:2004-09-25 02:42:32
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-cxnet-donotlosequotes-patch
Description:Example from README.variables:

exten => _XX.,1,GotoIf($["${calledid}" != ""]?3)

Jun 21 10:34:16 WARNING[475143]: ast_expr.y:467 ast_yyerror: ast_yyerror(): syntax error: syntax error; Input:
1234 !=
^^^^
       ^

# bison --version
bison (GNU Bison) 1.875

# asterisk -r -x "show version"
Asterisk CVS-06/21/04-09:11:26-CEST built by root@gw-10 on a i686 running Linux
Comments:By: thansen (thansen) 2004-06-21 04:47:10

Rolling back pbx/pbx_config.c to revison 1.38 seems to fix the problem.

Apparently the quotes gets stripped by the new escaping routine. I'm attaching a quick patch to work around this problem.
By: Mark Spencer (markster) 2004-06-21 09:15:41

Okay, two alternatives:

1) We make the pbx_config quoting be done with single quotes

2) We escape the quotes in the example

Thoughts?
By: Mark Spencer (markster) 2004-06-21 09:16:02

Oh, and obviously this does not meet the requirements of "MAJOR"
By: Mark Spencer (markster) 2004-06-21 10:32:24

The attached patch won't work because it forces the quotes to be in it.  It sounds like changing pbx_config to use ' instead of " for quoting might be the way to go.