[Home]

Summary:ASTERISK-01833: [patch] dynamic configuration in app_queue.c
Reporter:constfilin (constfilin)Labels:
Date Opened:2004-06-15 21:32:40Date Closed:2011-06-07 14:04:45
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue_no_space.patch
( 1) app_queue_no_space.patch
( 2) app_queue.patch
Description:The attached patch allows dynamic configuration of asterisk queues. Queue information is re-read from the configurable database in real time.

****** ADDITIONAL INFORMATION ******

Right now implemented only for postgres, no mysql
Comments:By: constfilin (constfilin) 2004-06-15 21:38:21

A little documentation:

on load_module, app_queue.c looks into [general] section of queue.conf and reads parameters like
  db_option
  db_getqueue_query
  db_getmembers_query
from this section.

db_option tells app_queue.c how to connect to a Postgres database,
db_getqueue_query tells app_queue.c how to select live queues from
the database and db_getmembers_query tells how get members of a
specific queue.

To use this app_queues.c dynamic conifguration, please set
USE_POSTGRES_QUEUES=1 in asterisk/apps/Makefile

Thanks

Constantine
By: constfilin (constfilin) 2004-06-15 21:39:44

PS: I won't be available for 2 weeks, so - if at all possible - put this into CVS. If not possible, then I will be able to reply on questions and produce newer patches in 2 weeks.

Thanks

-c
By: Mark Spencer (markster) 2004-06-15 22:30:18

Seems to be lots of superfluous whitespace changes...  Was there a reason?
By: constfilin (constfilin) 2004-06-15 23:04:44

There are only cosmetic reasons (field alignments in struct {}). I attached a new patch that ignores all changes in the whitespace.
By: Mark Spencer (markster) 2004-06-24 00:00:32

This patch has been obsoleted by the new extconfig stuff (extconfig.conf)
By: constfilin (constfilin) 2004-07-02 13:55:36

Please excuse me for the insistence, but the patch does more than extconfig.conf.

With extconfig.conf, a "reload" is necessary to let asterisk know about
changes in the queues. On the other hand, my patch makes sure that asterisk
knows about new configuration each time when it is made in the database.

Respectfully

-c
By: constfilin (constfilin) 2004-07-02 16:09:39

I synced app_queue.c with the latest CVS version and uploaded the new patch.
By: Olle Johansson (oej) 2004-07-16 11:26:05

Sent test request to mailing list
By: constfilin (constfilin) 2004-07-16 12:44:30

I submitted a test request to Asterisk developers list. Thank you very much!

-c
By: twisted (twisted) 2004-07-23 20:59:45

No response from list post yet - Housekeeping notice...  Thanks!
By: Mark Spencer (markster) 2004-07-23 23:23:43

I must be misunderstanding this patch, it appears that it's reloading all queues in the database every time someone joins a queue?  If so, that seems incredibly inefficient...
By: constfilin (constfilin) 2004-07-24 19:54:49

Mark, your understanding is accurate. When I initially wrote it, I didn't
quite understood how the queues, members and agents all work and now I will probably have to rework this patch.

Actually, I am not pushing for this specific patch. Other voicemail patches like ASTERISK-1791828 and ASTERISK-2022055 are more important. The patch about SIP friends in postgres is also important.


Thanks!

-c