Summary:ASTERISK-01815: [patch] remote hold notification support
Reporter:Paul Cadach (pcadach)Labels:
Date Opened:2004-06-14 03:20:17Date Closed:2008-01-15 15:22:12.000-0600
Versions:Frequency of
Environment:Attachments:( 0) asterisk.hold4.diff
( 1) asterisk.hold5.diff
( 2) asterisk.hold6.diff
( 3) asterisk.hold7.diff
Description:Short description:
1) added two control messages (AST_CONTROL_HOLD and AST_CONTROL_UNHOLD) to indicate holded and retrieved call;
2) ability to pause file playback and rewind it by 2 secs to allow continuous listening after call is retrieved from hold;
3) hold/unhold notifications are sent when call is being held by transfer, park, etc.
4) channel's variable "hold" indicates call leg is on hold;
5) chan_zap support for passing those notifications over PRI links.


One side effect - because hold notifications needs to be traversed over all call path, bridging code needs to be modified to allow passing AST_CONTROL_HOLD and AST_CONTROL_UNHOLD to other call leg (my hack for common bridging code at channel.c is included).
Comments:By: Mark Spencer (markster) 2004-06-14 09:07:28

This diff isn't against CVS head is it?

By: Paul Cadach (pcadach) 2004-06-14 10:26:00

Verified - applies cleanly to the current CVS head.

By: Paul Cadach (pcadach) 2004-06-16 13:49:10

Due to CALL PROCEEDING bridging changes this patch is sligtly outdated (requires to change codes for AST_CONTROL_HOLD and AST_CONTROL_UNHOLD at frame.h, all other is clean). Today I'd test it with BRI connection over PSTN - notification about held/resumed call goes through PSTN cleanly, ISDN phone shows related messages. COOL!

By: Mark Spencer (markster) 2004-06-26 16:58:28

Can you implement this without changing the channel structure?

By: Paul Cadach (pcadach) 2004-06-26 23:16:32

I'll try to fix this evening... Also, I'll update with changed AST_CONTROL_xxx codes.

By: Paul Cadach (pcadach) 2004-06-29 13:04:04

Updated. All stuff related to playout is removed (needs more things). Don't forget about forgotten patch for pri.c (pri_notify() implementation, pri.c.notify.diff) from ticket ASTERISK-1760 (missed from applying to CVS while other patches was applied).

By: Mark Spencer (markster) 2004-06-29 16:26:42

Why do we assume the caller to the bridge function doesn't want the hold/unhold function?  I'm starting to think this might need to be delayed post 1.0 anyway :-/

By: twisted (twisted) 2004-07-23 20:35:10

Any update?

By: twisted (twisted) 2004-10-27 15:44:59

okay, digging in the way-back machine here.  This was flagged for post-1.0 review.  Seeing the state of the bugtracker now, This is a call for action.

Please check current cvs and make patches apply cleanly, and let's get some more activity going on this bug, before we have to close it for being open w/o activity for too long.


By: Paul Cadach (pcadach) 2004-10-31 09:38:11.000-0600

asterisk.hold4.diff is for current CVS.

By: twisted (twisted) 2004-11-14 21:40:20.000-0600

Sweetness... now, if we can only get these to have a little more importance, since they're the older, more mature bugs that were flagged for post-1.0, pre-1.0.

By: Paul Cadach (pcadach) 2004-11-14 23:02:00.000-0600

asterisk.hold5.diff - just to be up with the current CVS-HEAD. The patch works pretty.

By: twisted (twisted) 2004-12-01 00:44:17.000-0600

Welp, gonna poke this one again.


By: twisted (twisted) 2004-12-15 20:35:53.000-0600

Last request for status


By: Paul Cadach (pcadach) 2004-12-21 12:03:15.000-0600

The patch is updated for the current CVS (2004-12-21 12:00:00 GMT-6).

By: twisted (twisted) 2005-01-04 01:23:08.000-0600

This still looks useful.   Hopefully this probe will get the attention it deserves..   markster, PCadach has kept this up for awhile, is it possible to revisit?

By: Mark Spencer (markster) 2005-01-16 01:34:18.000-0600

Yes, my fault for not getting to this sooner!  This does need to be updated to latest CVS and I need to get it in as soon as it is to avoid letting it become stale again!

By: Paul Cadach (pcadach) 2005-01-17 06:16:08.000-0600

Updated to the current CVS.

By: Mark Spencer (markster) 2005-01-17 06:36:04.000-0600

Added to CVS with modifications.  Please reopen if there are any problems with my changes.  Thanks!

By: Russell Bryant (russell) 2005-01-17 15:01:51.000-0600

not in 1.0

By: Digium Subversion (svnbot) 2008-01-15 15:22:12.000-0600

Repository: asterisk
Revision: 4823

U   trunk/apps/app_dial.c
U   trunk/channel.c
U   trunk/channels/chan_zap.c
U   trunk/include/asterisk/frame.h
U   trunk/res/res_features.c

r4823 | markster | 2008-01-15 15:22:11 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge hold patch (bug ASTERISK-1815)