Summary:	ASTERISK-01792: dsp.c won't compile with OLD_DSP_ROUTINES
Reporter:	thansen (thansen)	Labels:
Date Opened:	2004-06-10 04:49:39	Date Closed:	2004-09-25 02:43:28
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	dsp.c: In function `dtmf_detect': dsp.c:642: `DTMF_TO_TOTAL_ENERGY' undeclared (first use in this function) DTMF_TO_TOTAL_ENERY is not defined when using OLD_DSP_ROUTINES.
Comments:	By: Tilghman Lesher (tilghman) 2004-06-10 07:31:53 What specifically is not working for you when you leave OLD_DSP_ROUTINES undefined? By: thansen (thansen) 2004-06-10 07:54:23 I've been using OLD_DSP_ROUTINES since it was changed because too many calls got detected as fax calls (I assume that's what "tone detected on Zap... Disabling echo canceler" means) which resulted in the echo canceler being disabled. (On Zap-IAX2-SIP calls) You're asking this question because the OLD_DSP_ROUTINES is about to be removed? In that case, will faxdetect=no in zapata.conf effectively stop echo canceling from being disabled and will external modem and fax (Fax/Modem-PSTN-Zap-IAX2-SIP-POTS-Fax/Modem) still work with fax detection off? By: Tilghman Lesher (tilghman) 2004-06-10 07:59:15 The problem with the new dsp routines improperly detecting fax calls was fixed several months ago.  Are you still having problems with improperly detected fax calls with the current code? By: thansen (thansen) 2004-06-10 08:09:52 I have been unable to test it because all servers with Zaptel cards are used in production. I'll have to make sure Asterisk CVS HEAD is stable enough to use in production before upgrading these servers. By: Mark Spencer (markster) 2004-06-10 14:13:12 Also, fax detection/redirection is not turned on by default and must be explicitly enabled in zapata.conf in cvs head. By: Mark Spencer (markster) 2004-06-10 14:17:47 OLD_DSP_ROUTINES will not be around long in CVS head. By: Mark Spencer (markster) 2004-06-11 10:26:27 Did you get a chance to try out cvs head? By: Olle Johansson (oej) 2004-06-13 15:36:22 It doesn't compile on CVS head either with OLD_DSP_ROUTINES. It's the first line of fax detection routine that leads to errors. thansen: If you disable FAX_DETECT in dsp.c, dsp.c will compile with OLD_DSP_ROUTINES. If this doesn't work for you, please reopen bug. By: Olle Johansson (oej) 2004-06-13 15:37:25 Proposed a work-around, since OLD_DSP_ROUTINES are supposed to be removed according to markster.