[Home]

Summary:ASTERISK-01783: [patch] error building chan_h323 after mutex relative changes
Reporter:Dmytro Mishchenko (arkadia)Labels:
Date Opened:2004-06-09 06:44:12Date Closed:2004-09-25 02:43:28
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_h323_mutex.diff
Description:asterisk with chanh323 build fail

****** ADDITIONAL INFORMATION ******

gcc -pipe  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -g  -Iinclude -I../include -D_REENTRANT -D_GNU_SOURCE  -O6 -march=i686    -DASTERISK_VERSION=\"CVS-HEAD-06/09/04-13:52:32\" -DINSTALL_PREFIX=\"\" -DASTETCDIR=\"/etc/asterisk\" -DASTLIBDIR=\"/usr/lib/asterisk\" -DASTVARLIBDIR=\"/var/lib/asterisk\" -DASTVARRUNDIR=\"/var/run\" -DASTSPOOLDIR=\"/var/spool/asterisk\" -DASTLOGDIR=\"/var/log/asterisk\" -DASTCONFPATH=\"/etc/asterisk/asterisk.conf\" -DASTMODDIR=\"/usr/lib/asterisk/modules\" -DASTAGIDIR=\"/var/lib/asterisk/agi-bin\"     -DBUSYDETECT_MARTIN      -Wno-missing-prototypes -Wno-missing-declarations        -DCRYPTO -fPIC -DMYSQL_FRIENDS -DSIP_MYSQL_FRIENDS    -c -o chan_h323.o chan_h323.c
chan_h323.c:127: error: `__use_AST_MUTEX_DEFINE_STATIC_rather_than_AST_MUTEX_INITIALIZER__' undeclared here (not in a function)
chan_h323.c:127: error: initializer element is not constant
chan_h323.c:127: error: (near initialization for `userl.lock')
chan_h323.c:132: error: `__use_AST_MUTEX_DEFINE_STATIC_rather_than_AST_MUTEX_INITIALIZER__' undeclared here (not in a function)
chan_h323.c:132: error: initializer element is not constant
chan_h323.c:132: error: (near initialization for `peerl.lock')
chan_h323.c:137: error: `__use_AST_MUTEX_DEFINE_STATIC_rather_than_AST_MUTEX_INITIALIZER__' undeclared here (not in a function)
chan_h323.c:137: error: initializer element is not constant
chan_h323.c:137: error: (near initialization for `aliasl.lock')
Comments:By: Dmitriy Yermakov (dyer) 2004-06-11 04:20:43

quick patch attached.
chan_h323.c is succesfully compiled, asterisk is started normally,
registered on gatekeeper.
Test call from openphone/winxp - gnugk - * - ata-186 is passed.
By: Dmytro Mishchenko (arkadia) 2004-06-11 04:58:17

Hmm.. it seems to me that you are missing mutex initialization with this patch.

I'm using the folowing construction:

static struct ast_user_list {
       struct oh323_user *users;
       ast_mutex_t lock;
} userl = { NULL, AST_MUTEX_INIT_VAULE};

Its compiled fine but I didn't test if its really works.
By: Dmitriy Yermakov (dyer) 2004-06-11 09:06:58

oops :) yes, your are right, i'm wrong.
i'm missing between head and stable version.

i'm compiled and testing some test call.
Working properly.
By: jerjer (jerjer) 2004-06-11 22:41:09

fixed in cvs