Summary:ASTERISK-01741: [patch] meetme - make the announcement fd into a proper channel
Reporter:Tony Mountifield (softins)Labels:
Date Opened:2004-06-01 17:50:04Date Closed:2008-01-15 14:57:04.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_meetme.c.patch
( 1) app_meetme.c.patch.rev2
( 2) app_meetme.c.patch.test-example
Description:Now that chan_zap has recently had the requesting of pseudo channels fixed, it is possible to make the announcement fd for a conference into a proper channel. This will allow future enhancements to create threads to stream files to a whole conference, e.g. "<name> has joined", or "this conference will close in 5 minutes".

The raw fd is still available as conf->chan->fds[0] for use by conf_play() to send the enter/leave sounds as at present.


For this patch to work, it is essential that zapata.conf contains the line:

channel => pseudo

Note that the default sample of zapata.conf does not contain this line. Perhaps it now ought to.
Comments:By: Tony Mountifield (softins) 2004-06-01 17:51:23

Disclaimer was faxed today (Miton Systems Ltd, Tony Mountifield)

By: Mark Spencer (markster) 2004-06-01 18:38:48

If the ast_request fails, we should just open up the /dev/zap/pseudo device directly and use the fd.  You can't break operation on a current configuration.

By: Tony Mountifield (softins) 2004-06-02 05:01:08

Very good point. Revision 2 patch app_meetme.c.patch.rev2 uploaded which does this. This is a replacement for the original patch, not an addition, and preserves existing operation when zapata.conf does not include "channel => pseudo".

Also uploaded is an expeimental example patch for meetme that illustrates the playing of an announcement using a separate thread. It just plays a file when one of the participants presses '2'. This example is not intended for CVS.

By: Mark Spencer (markster) 2004-06-02 09:49:46

That begs an interesting question...  If the pseudo channel isn't listed, should we create one in chan_zap based on the defaults?

By: Mark Spencer (markster) 2004-06-02 12:40:56

Added (with some small corrections).

By: Digium Subversion (svnbot) 2008-01-15 14:57:00.000-0600

Repository: asterisk
Revision: 3125

U   trunk/apps/app_meetme.c

r3125 | markster | 2008-01-15 14:57:00 -0600 (Tue, 15 Jan 2008) | 2 lines

Use pseudo channel (but real channel) instead of just directly opening /dev/zap/pseudo to enable future meetme enhancements (bug ASTERISK-1741)



By: Digium Subversion (svnbot) 2008-01-15 14:57:04.000-0600

Repository: asterisk
Revision: 3130

U   trunk/apps/app_meetme.c

r3130 | markster | 2008-01-15 14:57:04 -0600 (Tue, 15 Jan 2008) | 2 lines

Use pseudo channel instead of just /dev/zap/pseudo, now with proper protections (bug ASTERISK-1741)