| Summary: | ASTERISK-01693: zaptel modules cleanup for 2.6.x | ||
| Reporter: | Tony Hoyle wibble wibble wibble (tonyhoyle) | Labels: | |
| Date Opened: | 2004-05-26 10:02:59 | Date Closed: | 2004-09-25 02:45:05 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | some modules (wcfxo and wcfxs) are missing the end terminator on their pci_device_id table, which causes oopses. This patch also has some tidying to make the modules conform to 2.6.x standards (MODULE_DEVICE_TABLE and __devexit_p mostly). The missing terminators are a crashing bug. The rest is just me being pedantic :) | ||
| Comments: | By: Tony Hoyle wibble wibble wibble (tonyhoyle) 2004-05-26 10:04:16 Ahh the file attachment didn't work. It's on http://www.nodomain.org/asterisk/zaptel_26.diff By: Mark Spencer (markster) 2004-05-26 10:44:26 Hrm, out of curosity, why did you remove the __devinitdata indicator? In principle that should save some kernel memory to have it there. By: Tony Hoyle wibble wibble wibble (tonyhoyle) 2004-05-26 10:53:28 Most of the drivers in the 2.6.5 kernel don't have it any more (only 17 drivers use it out of 600). I just followed what seemed to be the standard. By: Mark Spencer (markster) 2004-05-26 11:31:52 Fixed in CVS | ||