| Summary: | ASTERISK-01682: AddQueueMember command doesn't support wrapuptime | ||
| Reporter: | moorejon (moorejon) | Labels: | |
| Date Opened: | 2004-05-23 23:11:50 | Date Closed: | 2008-01-15 15:00:48.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) app_queue.c | |
| Description: | When adding members to a queue with the AddQueueMember command the new members are not given any wrapuptime between calls. This feature is supported for Agents. ****** ADDITIONAL INFORMATION ****** I have coded a temporary work around for 0.7.2/0.9.0 for a client that requires this feature. Minor testing appears to show no side effects. It is a two line change wrapping a while loop with an if statement to check that the last call time minus current time is more than the wrapuptime (hard coded in the if statement). A cleaner implementation would be to add a wrapuptime keyword to queue.conf setup similar to agent.conf. If done though I would suggest not setting it in milliseconds and stored with an int. If I remember correctly c ints only support about 32,000 values if signed. So if value is stored in milliseconds this only allows for about 30 seconds of wrapuptime. Attached file is for 0.7.2 It modifies the try_calling function. It places if((time(NULL) - cur->lastcall)>45) { /* Test for wrapup time */ write after the while(cur) line and closes the if statement just before the line cur = cur->next; | ||
| Comments: | By: Brian West (bkw918) 2004-05-24 00:46:57 Ok this needs to be a config options. I'll see if I can whip up something tommorow. bkw By: Mark Spencer (markster) 2004-05-24 15:45:31 Please do not list feature requests as "minor" bugs. thanks! By: Olle Johansson (oej) 2004-06-09 14:44:17 Any whip ups on the way? House cleaning reminder :-) By: moorejon (moorejon) 2004-06-09 15:25:17 Sorry about the mix up. Just getting started with this and I was sure whether this would be considered a bug, since it doesn't much up with the other member login options, or a new feature. The attached code really doesn't fix anything at this point. I need to backport your lastcall fixes and see if my conditional loop works. By: Mark Spencer (markster) 2004-06-26 12:41:18 Queue wide wrapuptime support added. wrapuptime may now be declared for a queue. By: Digium Subversion (svnbot) 2008-01-15 15:00:48.000-0600 Repository: asterisk Revision: 3317 U trunk/apps/app_queue.c U trunk/configs/queues.conf.sample ------------------------------------------------------------------------ r3317 | markster | 2008-01-15 15:00:47 -0600 (Tue, 15 Jan 2008) | 2 lines Implement queue wide wrapuptime (bug ASTERISK-1682) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3317 | ||