Summary:	ASTERISK-01657: ADSI configuration in VM is incorrect
Reporter:	Steven Sokol (ssokol)	Labels:
Date Opened:	2004-05-19 16:12:36	Date Closed:	2008-01-15 14:55:58.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail.c.adsipatch.txt
Description:	The security and application descriptors for ADSI that are in the app_voicemail.c code are incorrect (at least they don't work with the ADIS phones that come from Sayson through the digium distributors.  Also, VM seems to insist on downlading the script at the beginning of each call.  Very slow and awkward. ****** ADDITIONAL INFORMATION ****** This is happening on my system using a TDM422b with a Sayson Aastra 480.  I will try to upload a patch to support the phones.  A better answer would be to put the security and application descriptors in voicemail.conf, but I have no idea with the results of that would be.  The current configuration only supports 1 brand/model of ADIS phones -- that seems limiting.
Comments:	By: Mark Spencer (markster) 2004-05-20 02:06:56 Do you have a patch? By: Steven Sokol (ssokol) 2004-05-20 17:21:49 Here's a tiny patch that sets the discriptor to use the first slot of a Sayson Aastra phone that is security-locked for Asterisk.  Eventually we may want to make the secuity info a parameter on a user-by-user basis in Voicemail, since the codes here are specific to the Astra phone. By: Mark Spencer (markster) 2004-05-21 00:28:33 Does this conflict with adsiprog? By: Mark Spencer (markster) 2004-05-22 18:13:35 To clarify, does this use the same slot that ADSI programs asterisk.adsi into? By: Steven Sokol (ssokol) 2004-05-22 20:08:28 Mark, This update programs the VM application into Slot 1 on the Sayson Aastra phones.  On these phones (the 380 and 480) slot 1 is a loadable application slot.  Slot 2 is the auto-load slot and that's where the asterisk.adsi gets loaded.  I will post a patch to asterisk.adsi that has the proper security code for slot 2. I still think we need to make the security code settable on a user-by-user basis, on the off chance somebody has a different ADSI phone.  I've been working on the ast_data stuff recently.  I think I will go ahead and add the code into that to the values (adsi_code and adsi_app or some such thing) to VM. Does that make sense, or am I heading in the wrong direction here? Thanks Steven By: Mark Spencer (markster) 2004-05-23 20:31:07 Fixed in CVS By: Digium Subversion (svnbot) 2008-01-15 14:55:58.000-0600 Repository: asterisk Revision: 3050 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r3050 | markster | 2008-01-15 14:55:57 -0600 (Tue, 15 Jan 2008) | 2 lines Fix voicemail ADSI codes (bug ASTERISK-1657) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3050