[Home]

Summary:ASTERISK-01611: [Patch] Basic code to remove hardcoded ENTER and LEAVE signal
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2004-05-13 16:39:50Date Closed:2004-09-25 02:17:29
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme.c_filepromptbuffered.diff
( 1) app_meetme.c-fileprompt.diff
( 2) enter.raw
( 3) leave.raw
Description:This is just the basic patch of probably future patch to allow GSM/WAV... file format as enter/leave, and also make it configurable

****** ADDITIONAL INFORMATION ******

Base on request from Connor
Comments:By: Mark Spencer (markster) 2004-05-13 18:01:51

Hrm, in a high performance environment, it might be an advantage to not read from the file.  What about making this an option somehow?  Also, why use file * instead of just int fd and then do read?

By: mochouinard (mochouinard) 2004-05-13 18:04:29

What about loading the 2 enter/leave into the conf struct when the conference is created instead then ?

By: mochouinard (mochouinard) 2004-05-13 19:55:16

app_meetme.c_filepromptbuffered.diff SHOULD buffer in conf structure.  So it will only read the file the first time the conference is created.

By: Mark Spencer (markster) 2004-05-15 12:56:09

I'm going to merge this with 1632, since that is a place for more general discussion.