[Home]

Summary:ASTERISK-01590: [patch] manager_event and run_externnotify don't use context
Reporter:nicolasg (nicolasg)Labels:
Date Opened:2004-05-11 14:34:41Date Closed:2008-01-15 14:54:31.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) voicemail.patch
( 1) voicemail.patch
Description:app_hasvoicemail and run_externnotify only use the mailbox number when run, without using the context.

In asterisk manager events, this means that it only works with mailboxes in the default context. If the mailbox is in a context other than 'default', it will not report new messages (it always returns 0).

This patch fixes that.

****** ADDITIONAL INFORMATION ******

Tested only by me. Need more testers!

I already sent the disclaimer on january for bug 772.
Comments:By: sbingner (sbingner) 2004-05-11 14:54:06

Patch looks ok to me, I'll test when I get home...
By: James Golovich (jamesgolovich) 2004-05-11 15:45:00

Looks fine in the functionality department, but I've got a small formatting complaint.

+ snprintf(ext_context, sizeof(ext_context), "%s@%s",ext,vmu->context);

Notice how the first few args are sepearted with a comma and a space, and the later args are seperated with just a comma.  Please keep it consistent
By: nicolasg (nicolasg) 2004-05-11 17:27:38

Hi James,

I corrected the formatting. My mistake. Please remove the first patch file if you can. Thanks!
By: Mark Spencer (markster) 2004-05-11 20:04:29

Added to CVS, thanks.
By: Digium Subversion (svnbot) 2008-01-15 14:54:31.000-0600

Repository: asterisk
Revision: 2950

U   trunk/apps/app_voicemail.c
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r2950 | markster | 2008-01-15 14:54:30 -0600 (Tue, 15 Jan 2008) | 2 lines

Put sip history stuff in (for real) and provide voicemail context (when not default) in some critical places (bug ASTERISK-1590)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2950