[Home]

Summary:ASTERISK-01584: [patch] Add explanations of functions in chan_sip.c
Reporter:Olle Johansson (oej)Labels:
Date Opened:2004-05-10 15:49:25Date Closed:2008-01-15 14:54:38.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sipcomments.txt
Description:This patch
* Adds a one-line description to most functions in chan_sip.c
 (Mark: Please check for correctness)
* Adds one bkw patch for useragent simplification
* Adds more compressed SIP commands to the parsing table
* Adds more translations between Asterisk states/hangup causes and SIP
Comments:By: Olle Johansson (oej) 2004-05-10 16:08:11

Removed bkw patch since it's already committed.
By: Mark Spencer (markster) 2004-05-11 22:56:34

Mostly okay but:

1) 404 is AST_CAUSE_UNALLOCATED not FAILURE

2) The use of !ast_strlen_zero() isn't valid since we're really checking for non-NULL.  You can use if (foo && !ast_strlen_zero(foo)) if you want

Anyway will be happy to apply when fixed.
By: Olle Johansson (oej) 2004-05-12 02:35:16

Mark: Did you have time to check that my comments about the functions was correct?

Thank you for the corrections, I'll change.

/O
By: Mark Spencer (markster) 2004-05-12 15:07:29

sipouraddrfor is not just for NAT...

sipack acknowledges receipt of a packet and stops retransmission.

sip-semi-ack acknowledges receipt of a packet but keeps it around since
it's only a provisional response.

send_request is not always "to the network" but to the other side.

sip_alloc: it's a SIP_PVT not SIP_VT structure


only comment changes i see that need fixing.
By: Olle Johansson (oej) 2004-05-13 14:30:51

Ok, new patch uploaded. Mark, thank you for your help.
By: Mark Spencer (markster) 2004-05-13 15:43:57

Added to CVS, thanks!
By: Digium Subversion (svnbot) 2008-01-15 14:54:38.000-0600

Repository: asterisk
Revision: 2959

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r2959 | markster | 2008-01-15 14:54:38 -0600 (Tue, 15 Jan 2008) | 2 lines

Better document SIP (bug ASTERISK-1584)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2959