[Home]

Summary:ASTERISK-01543: [Patch] Would like 'r' option for app_queue to work
Reporter:connor (connor)Labels:
Date Opened:2004-05-04 21:27:59Date Closed:2008-01-15 14:54:16.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.diff.txt
Description:App queue should be able to ring instead of playing MOH for some advanced phone-pooling functions.
Comments:By: Brian West (bkw918) 2004-05-04 21:50:29

Please fix according to the coding style guide in doc/ use tabs and not spaces.

By: connor (connor) 2004-05-04 21:58:47

Sorry, backlash of perl coding days. Fixed.

By: Brian West (bkw918) 2004-05-05 01:14:12

Ok this patch is wrong.  Find me on IRC and i'll give input.

By: connor (connor) 2004-05-05 09:59:20

okay, lets try this again..  New patch.. made a typo when I was changing the spaces to tabs.

By: Mark Spencer (markster) 2004-05-06 11:34:57

Looks pretty good, one more request -- can you document it show "show application queue" mention it?

By: connor (connor) 2004-05-06 12:20:05

OKay, that's done.  I have one concern..  This patch doesn't do anything with the MOH for the announce position in queue stuff...  How do we want to handle that? Or do we just assume if they're doing the 'r' option they're not going to do announce position in queue.

By: connor (connor) 2004-05-07 10:51:24

OKay, made it so that if the 'r' option is passed, it will "disable" anounce position.

By: Mark Spencer (markster) 2004-05-09 15:04:06

Added to CVS, thanks!

By: Digium Subversion (svnbot) 2008-01-15 14:54:16.000-0600

Repository: asterisk
Revision: 2933

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r2933 | markster | 2008-01-15 14:54:15 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge Connor's ringback feature for queue (bug ASTERISK-1543)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2933