[Home]

Summary:ASTERISK-01518: [pre-1.0]? [patch] MeetMe, Hold everyone until Admin Login
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2004-05-05 20:18:56Date Closed:2011-06-07 14:05:11
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme.c_v3.diff
( 1) app_meetme.c.20040703b.diff
( 2) app_meetme.c.20040703c_experimental.diff
( 3) app_meetme.c.cvs040704e.diff
( 4) app_meetme.c.cvs20040703.diff
( 5) app_meetme.c.diff
( 6) app_meetme.c.diff
( 7) conf-adminhasleft.gsm
( 8) conf-placeintoconf.gsm
( 9) conf-userwilljoin.gsm
(10) conf-waitforchairman.gsm
(11) meetme.conf.sample.diff
Description:by adding A to the flags of the conference, it will make wait everyone until the ADMIN get into the conference.
you need 2 new audio file :
conf-placeintoconf.gsm : You will now be placed into the conference
conf-waitforchairman.gsm : Conference will start once the chairman has arrive
Comments:By: Brian West (bkw918) 2004-05-05 20:49:36

I see no update to the app documentation. :)  Update that

bkw
By: twisted (twisted) 2004-05-05 20:56:10

moved to applications, as this is not acd :)
By: Mark Spencer (markster) 2004-05-05 21:27:14

That if statement at the top can be turned around and the first part made an else clause, other than that looks nicely done.
By: mochouinard (mochouinard) 2004-05-05 23:27:40

New update :
- flags h if you want to make everyone exit the conference when chairman leave. If not set, it will put everyone back into MOH(if no MOH, need to find a way to give all channels no audio (currently they are in the conference I think)
- I try to make sure to keep using the _QUIET and _MOH paramaters
- New message conf-adminhasleft.gsm when the admin leave the conference

edited on: 05-05-04 22:24
By: fabeman (fabeman) 2004-05-06 10:25:10

Hey, mochouinard
i'm working on quite the same stuff
and i did something more to improve the management abilities of app_meetme.
perhaps we could have a talk about this and merge our patches/features ?
can i find you in irc?
(i'm Fabe in #asterisk on freenode)
By: mochouinard (mochouinard) 2004-05-06 15:40:56

Should now put everyone mute if no moh is activated
Also wont quit unless all admin has quit
Added the r flags to force the posibility to retry for example if PIN is incorectly entered

edited on: 05-06-04 18:39
By: Mark Spencer (markster) 2004-05-25 01:36:37

Now that we've merged that major meetme patch in, it would be a better time to work on this patch, too.  What's your status?
By: mochouinard (mochouinard) 2004-05-25 10:11:06

I'll try to update it to HEAD tonight.
By: mochouinard (mochouinard) 2004-05-25 23:33:38

Ive uploaded a new version that should work with HEAD, I havent tryed it yet, just made sure it compile without error. Let me know if you have any problems
By: mochouinard (mochouinard) 2004-06-04 19:37:47

Ive uploaded another version that work with new HEAD... seem stable from my end... let me know how it does from yours.

Thanks
By: mochouinard (mochouinard) 2004-06-04 19:45:10

Im not english so I dont know what should be the exact prompt My guess are :
Conference will start once the chairman has arrived.
The chairman has left the conference.  (Goodbye ???)
You will now be placed into the conference.
By: Mark Spencer (markster) 2004-06-23 01:09:32

I've added a "w" option, is my version sufficient for your needs?
By: mochouinard (mochouinard) 2004-06-27 16:50:38

ok so you ratter use the marked users than the admin count ?
By: Mark Spencer (markster) 2004-06-27 16:59:56

Seems a little more logical to me, does it still fit your needs?
By: Mark Spencer (markster) 2004-06-28 19:47:26

Please let me know if the version in CVS meets your needs.  Thanks!
By: Mark Spencer (markster) 2004-07-01 18:24:20

Assuming what we do now is good enough.
By: mochouinard (mochouinard) 2004-07-03 02:23:50

Arn't we missing Voice file for the "Conference will start once the chairman has arrive " (currently play vm-dialout from what I can read.

Missing the section for the prompt when the Admin join the conference so that the user will be placed into the conference

Missing the section for the prompt when the Admin leave the conference before cutting everyone.

Also I had added r flag + MAXRETRY variable for set retry on error if user dont type the good password for the conference.
By: mochouinard (mochouinard) 2004-07-03 12:46:34

Ok Im making a new patch at the moment... My problem now is markedusers. Im going to change things back to the way I made it since marked user is limited. it mark a user base on the hangup flag.  It make more sence that the marked user are basicly the admin of the conference, the chairman. Im going to change all that right away
By: mochouinard (mochouinard) 2004-07-03 13:01:42

Ok so here we go, let me know what you think.
By: mochouinard (mochouinard) 2004-07-03 14:25:24

Ok I give up, Im just gonna use the old code, Ive being trying to fix meetme problem but with it current setup it aint good... old one work better in my view. The patch I submited is broken since and I not going to fix it with the way meetme is being handle currently...
By: mochouinard (mochouinard) 2004-07-03 15:12:26

I havent gave up completely... Im changing thing the way it was before, or kind of.

1 thing I saw is CONFFLAG_VIDEO aint used anymore (was used to call  : Set it into linear mode (write) (read)) Dont know if it needed anymore, is linear mode better or less good ? or the same so flag is useless ?
By: mochouinard (mochouinard) 2004-07-03 15:30:05

Ok this look better and work as previous patch.
2 other feature Im lookin to add
1 - When wait for admin is on, he can select menu and login as admin. the idea is no need to configure 2 extension for a conference, just have 1 pin for user and 1 pin for admin. So maybe a prompt like : Conference will start once the chairman has arrived. If you are the chairman please press #.
2 - When the admin join, he get the prompt of the number of user that will join the conference. So something like : 32 user has join the conference

Let me know what you think....
By: mochouinard (mochouinard) 2004-07-03 18:05:48

What should be the prompt for the admin to hear the number of user in the conference ? something like :
10 user has join the conference ?

here the code to add before the for (;;) { :
               if ( !(confflags & CONFFLAG_QUIET) && conf->admins == 1 && conf->users > 1 && confflags & CONFFLAG_ADMIN ) {
                       ast_say_number(chan, conf->users - 1, AST_DIGIT_ANY, chan->language, (char *) NULL);
                       /* user will join the conference */
               }

It need the second wave file
By: mochouinard (mochouinard) 2004-07-03 18:53:31

the app_meetme.c.20040703c_experimental.diff add the 2 thing I wanted to do except it need finishing.
when in line as user in the conference you can press * and once she finish speaking press 2 and it will ask you for the admin pin, for the moment it the SAME as the user pin. I beleive meetme should be control from the meetme.conf ratter than the extension.conf, all the options for the conference should be moved, but it open for discution.

The second that I show in a bugnote is in also EXCEPT when user press * 2 it doesn't tell it, I would need to copy the same code, but the first section aint completed yet also since we dont have the prompt. So I'll wait to duplicate it down there.

Please let me know what you think
By: mochouinard (mochouinard) 2004-07-04 23:51:48

Here the list the lastest patch should be doing:
- Hold everyone until Admin login
- When admin join, he get a prompt about how many users will join the conference(was on hold)
- Prompt to the user about waiting for the admin
- Prompt when the admin join the conference
- Prompt when the admin leave the conference
- Allow retry when asked for pin
- Added a adminpin in meetme.conf
- Beable to login as admin when current a user(or waiting for admin) (option * 9)
By: twisted (twisted) 2004-07-23 20:42:15

Can we:

1) Clean up this file list
2) finalize where we want to head with this

and

3) make a decision - post-1.0 or pre-1.0?
By: mochouinard (mochouinard) 2004-07-23 21:17:05

Im using that patch with the CVS running version up there for a while without problem(head meetme had more problem)

I'll try to update it this weekend. also we still need to decide of the prompt to be recorded
By: mochouinard (mochouinard) 2004-08-09 22:36:05

Ok, since this will never get to CVS as a whole... I decided to split EVERYTHING is smaller bug report, so that peice by peice it get to CVS.

So I'll keep this bug to keep myself updated what I will have to migrate, but furter patch on different subject will be done via other bug report
By: Mark Spencer (markster) 2004-08-10 07:24:31

Okay, we'll close this one out then and get the individual ones piece-by-piece as discussed.  Thanks!