[Home]

Summary:ASTERISK-01494: Key Bounce (with SIP INFO messages)
Reporter:octothorpe (octothorpe)Labels:
Date Opened:2004-04-28 17:58:59Date Closed:2008-01-15 14:52:29.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I was having problems logging into voicemail from a BugetTone phone -- getting "invalid password" -- so I turned on "sip debug".  What was happening was that retransmissions of SIP INFO messages (same CSeq) were being processed as new, so a password of "1234" might be read as "12234".

****** ADDITIONAL INFORMATION ******

The following change to chan_sip.c fixed it:

Index: chan_sip.c
===================================================================
RCS file: /usr/cvsroot/asterisk/channels/chan_sip.c,v
retrieving revision 1.336
diff -u -r1.336 chan_sip.c
--- chan_sip.c 19 Apr 2004 22:55:35 -0000 1.336
+++ chan_sip.c 28 Apr 2004 21:52:09 -0000
@@ -5614,9 +5614,11 @@
p->needdestroy = 1;
transmit_response(p, "200 OK", req);
} else if (!strcasecmp(cmd, "MESSAGE")) {
- if (sipdebug)
- ast_verbose("Receiving message!\n");
- receive_message(p, req);
+ if(!ignore){
+ if (sipdebug)
+ ast_verbose("Receiving message!\n");
+ receive_message(p, req);
+ }
transmit_response(p, "200 OK", req);
} else if (!strcasecmp(cmd, "SUBSCRIBE")) {
if (!ignore) {
@@ -5684,9 +5686,11 @@
   transmit_state_notify(p, ast_extension_state(NULL, p->context, p->exten),1);
}
} else if (!strcasecmp(cmd, "INFO")) {
- if (sipdebug)
- ast_verbose("Receiving DTMF!\n");
- receive_info(p, req);
+ if(!ignore){
+ if (sipdebug)
+ ast_verbose("Receiving DTMF!\n");
+ receive_info(p, req);
+ }
transmit_response(p, "200 OK", req);
} else if (!strcasecmp(cmd, "REGISTER")) {
/* Use this as the basis */
Comments:By: Mark Spencer (markster) 2004-04-28 18:05:36

Fixed in CVS
By: Digium Subversion (svnbot) 2008-01-15 14:52:29.000-0600

Repository: asterisk
Revision: 2808

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r2808 | markster | 2008-01-15 14:52:28 -0600 (Tue, 15 Jan 2008) | 2 lines

Don't double receive INFO or MESSAGE elements (bug ASTERISK-1494)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2808