[Home]

Summary:ASTERISK-01488: [PATCH] Add "accountcode" support to MySQL based IAX-FRIENDS
Reporter:nix (nix)Labels:
Date Opened:2004-04-28 13:21:10Date Closed:2004-09-25 02:49:37
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) iaxfriends-accountcode.diff
Description:Add "accountcode" support to MySQL based IAX-FRIENDS
Note: 3 line patch plus 1 line DB schema change.
Comments:By: Brian West (bkw918) 2004-04-28 13:40:25

Good idea.. i'll see about getting mark to look at it ASAP. :)

By: Malcolm Davenport (mdavenport) 2004-04-28 17:20:01

Is there a reason that you didn't include the "accountcode" field in the SELECT on line 1835 also in the .diff?

By: nix (nix) 2004-04-29 15:04:05

Yes, because unless I am reading the code wrong the iax2_peer structure does not have and accountcode. I only started with the chan_iax2.c code last night so I could be wrong, but it seems that only iax2_user(s) need an account code because they can generate calls. iax2_peer(s) cannot and therefore don't need an associated account code.... I think..
In any case I tried it just for kicks and got the following:
chan_iax2.c: In function `mysql_peer':
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
chan_iax2.c:1858: error: structure has no member named `accountcode'
make[1]: *** [chan_iax2.o] Error 1
make[1]: Leaving directory `/usr/src/asterisk/channels'
make: *** [subdirs] Error 1

By: Malcolm Davenport (mdavenport) 2004-04-29 16:02:21

Added to CVS.  Thank you.