Summary:ASTERISK-01438: [patch] for SIP phones asterisk shows itself as caller ID when caller ID is actually unknown/undefined
Reporter:chrisorme (chrisorme)Labels:
Date Opened:2004-04-20 05:43:28Date Closed:2011-06-07 14:10:24
Versions:Frequency of
Environment:Attachments:( 0) calleridtweak.txt
( 1) calleridtweak.txt
Description:Asterisk displays caller id on SIP phones of 'asterisk' and not 'unknown' when the callers ID is unknown (or withheld).


This may not be a bug but it's something my field testers commented on and I changed.
I thought as I changed the code I should publish this change (GPL) or incase it helped others, or in case it was a useful change you wanted.
Comments:By: chrisorme (chrisorme) 2004-04-20 06:43:40

I have a feeling this does change what the phone sees but does all sorts of other things too which aren't wanted.

By: twisted (twisted) 2004-04-20 07:29:10

chrisorme: the code to * is always GPL, but to include any code changes or patches, etc, in cvs, you must file a disclaimer with digium.  See the main page for the disclaimer txt, and fax that in, and any appropriate patches that are made, can be added to CVS if need be.

By: chrisorme (chrisorme) 2004-04-20 07:31:41

do you think this patch has any chance of inclusion though, if not isn't it pointless me doing the disclaimer ?

By: chrisorme (chrisorme) 2004-04-20 08:12:45

ok - I faxed the Disclaimer.  Not so much for now but hoping that I'll write something in the next couple of months worthy of consideration.

By: chrisorme (chrisorme) 2004-04-20 08:13:57

but of course it's still valid for now if this is any good

By: Olle Johansson (oej) 2004-04-20 08:47:47

Chris, try implementing this in the dial plan first. You can check the caller id there, and set it to whatever you want if it's unknown. If this doesn't work, add another note here.

By: Brian West (bkw918) 2004-04-20 09:55:45

I agree with oej you can do this in the dial plan.

By: chrisorme (chrisorme) 2004-04-20 09:58:12

Ok, sorry, will try and find out how to.

What I need is if the incoming call (from IAX2) hasn't got caller id info attached to it already then to pass 'unknown' to the SIP device that is being dialled as the caller id.

I probably need an agi I guess.  ouch.  - I guess you can 'not a bug' this then.

By: Olle Johansson (oej) 2004-04-20 11:47:33

Check the variable stuff - cut, and variable comparision with $[ ]
You will not need agi for this. README.variables is a good start :-)