[Home]

Summary:ASTERISK-01405: [patch] make app_queue log AgentCallBackLogin
Reporter:lramos (lramos)Labels:
Date Opened:2004-04-14 07:11:59Date Closed:2004-09-25 02:14:12
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) agent_callback_events_1546.diff.txt
( 1) agent_callback_events.diff.txt
( 2) agent_callback_events.diff.txt
Description:New APP_Queue doesn't log Agents Login/out with AgentCallBackLogin

****** ADDITIONAL INFORMATION ******

Maybe it would be good to save the login/logout information with 2 new events like AGENTCBLOGIN and AGENTCBLOGOUT
Comments:By: zoa (zoa) 2004-04-26 10:49:25

is this still an issue ?

By: lramos (lramos) 2004-04-26 11:26:26

Yes, at least with the last week head CVS.
But this is not a bug, this is something that should be addded to the app_queue.c, because it was omitted.

By: vgeller (vgeller) 2004-04-27 20:21:17

This would be very useful, great idea! I believe, the same applies to AgentLogin.

By: twisted (twisted) 2004-05-02 22:51:04

updated the subject line to something more appropriate

By: Frank Mandarino (fmandarino) 2004-05-10 15:06:44

The attached chan_agent.c patch adds new events and queue log file entries to record agent callback logins, logoffs and autologoffs.  It also adds uniqueid fields to existing agent login and logoff events.

The new events are:

Event: Agentcallbacklogin
Agent: 1234
Extension: 1234567
Context: office
Uniqueid: 1084212578.11

Event: Agentcallbacklogoff
Agent: 1234
Uniqueid: 1084214649.19

or, if the agent was autologged off:

Event: Agentcallbacklogoff
Agent: 1234
Autologoff: 15
Uniqueid: 1083872836.185

The new queue_log entries are:

1084212591|1084212578.11|NONE|Agent/1234|AGENTCALLBACKLOGIN|1234567@office

1084214663|1084214649.19|NONE|Agent/1234|AGENTCALLBACKLOGOFF|

1084205881|1083872836.185|NONE|Agent/1234|AGENTCALLBACKLOGOFF|Autologoff

I would appreciate any comments or suggestions for improvements to this patch, with the hope that it might someday be incorporated into the CVS source.

Also, could someone update the Summary line to indicate [patch] instead of
[request]?

By: Frank Mandarino (fmandarino) 2004-05-12 17:25:07

Note that I have faxed a disclaimer.

By: Frank Mandarino (fmandarino) 2004-05-13 11:48:54

I have updated this patch with a slight change to the Autologoff event to specify the reason for the logoff:

Event: Agentcallbacklogoff
Agent: 1234
Reason: Autologoff
Uniqueid: 1083872836.185


Also, I have attached another patch (agent_callback_events_1546.diff.txt) which generates an Agentcallbacklogoff event and AGENTCALLBACKLOGOFF queue_log message when the "agent logoff" CLI command is performed (see Bug 1546).  The patch in Bug 1546 must be applied before this patch.

The new event and log message are formatted as:

Event: Agentcallbacklogoff
Agent: 1234
Reason: CLI

1084458318|NONE|NONE|Agent/1234|AGENTCALLBACKLOGOFF|CLI


The patches in this Bug are essential for monitoring and tracking agents when the "callback" method of logging in is used.  It seems strange that such events/logging are currently only available for the "always connected" logins.

I firmly believe that they would make a valuable addition to the Asterisk system, but so far they have generated very little interest, even from the original bug reporter.

Perhaps it would help if the Summary line was changed to:

 [patch] Generate AgentCallbackLogin monitor events and queue_log messages.

and the Severity was updated from "trivial" to at least "minor".  Could I ask one of the Bug Marshalls to consider this?

If there is anything else I can do to progress this bug, please let me know.

By: Mark Spencer (markster) 2004-06-03 11:17:50

This feature has now been obsoleted by ASTERISK-1750.