[Home]

Summary:ASTERISK-01399: [PATCH] chan_h323.c needs the recent change to dtmf duration that was made elsewhere
Reporter:cloos (cloos)Labels:
Date Opened:2004-04-12 22:03:41Date Closed:2008-01-15 14:52:49.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 323.diff
Description:the change from 300 to 800 samples also needs to be made in chan_h323.c
Comments:By: twisted (twisted) 2004-04-18 12:17:28

Does this have any adverse effect on chan_h323? (I don't really see where it would, but we need to test as thorough as possible)  Also, does it compile cleanly against both CVS stable and head?

edited on: 04-18-04 11:11

By: cloos (cloos) 2004-04-18 13:36:05

I had mis-read the code when I sent that; the code is for dtmf events received from h323 endpoints, not sent to them as I had tought.

Nonetheless, there is no reason for it not to compile against any version; it is only a s/300/800/ on a single line...

I have compiled it on head w/o problems.

By: Mark Spencer (markster) 2004-04-26 09:32:42

yes, but as far as i know it doesn't do anything at all since DTMF frames don't use the ->samples stuff.

By: jerjer (jerjer) 2004-04-30 01:12:22

commited to cvs...don't expect much (if anything) to change, but who knows, right?

By: Digium Subversion (svnbot) 2008-01-15 14:52:49.000-0600

Repository: asterisk
Revision: 2833

U   trunk/channels/chan_h323.c

------------------------------------------------------------------------
r2833 | jeremy | 2008-01-15 14:52:49 -0600 (Tue, 15 Jan 2008) | 2 lines

Increase DTMF duration in f.sample, just in case. ASTERISK-1399

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2833