[Home]

Summary:ASTERISK-01398: [patch] app_queue and cdr updates
Reporter:mystiqo (mystiqo)Labels:
Date Opened:2004-04-12 19:29:10Date Closed:2011-06-07 14:10:35
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20040423-queue.patch
( 1) queue.patch
Description:When using the Queue application, outgoing calls to operators/members of a queue don't get added to the cdr.
In a situation where the logged in members (through e.g. AddQueueMember) need to know their cdr statistics, this data can't be retrieved.

****** ADDITIONAL INFORMATION ******

The only thing i see in the cdr is the incoming call leg (that of the user), i don't see any info about the member/operator which is called, nor the call duration.
Comments:By: mystiqo (mystiqo) 2004-04-23 16:22:25

Ok, close this bug.. found some time to look at the app_queue code and patched it. Will eventually upload the patch.

For patches of, say 4 unique lines, do we need to fax a disclaimer ?
By: Brian West (bkw918) 2004-04-23 16:41:20

yes disclaim this and attach a patch.

Thanks,
bkw
By: Brian West (bkw918) 2004-04-23 16:57:10

Also I wanna see/test the fix :)
By: mystiqo (mystiqo) 2004-04-23 17:34:04

Ok, uploaded the current patch (the one we are using for our queues).

Some extra notes,
* at the moment we 'drop' the CDR record for the incoming call leg (the user), this can be changed by changing the '0' (last argument) on ast_cdr_reset to '1'.
(should be an option in queues.conf)
* this patch also sets the accountcode to the queuename, probably this should also be configurable

So, if i find the time, I'll fix those issues and upload the updated patch.

For the time being I already uploaded the patch so others can check it out, maybe test it already, etc.

We use it for 12 queues at the moment, and the CDR statistics are gathered by a cron process, and inserted in a queue-stats table.
These stats can then be viewed through our webinterface by customers.
We also use these stats to bill our customers..

Extra note: this is a rather quickfix, didn't have a lot of time, so I've no idea if this patch impacts other queue functionalities.
By: jerjer (jerjer) 2004-04-29 22:38:13

i can't apply this to my cvs -head copy of app_queue.

patch: **** malformed patch at line 13: @@ -507,6 +512,11 @@
By: twisted (twisted) 2004-05-02 20:34:34

Also, found a workaround that markster approved of to rotate the queue logs... hehe

if you look in the latest checkout logger.conf.sample file you'll see this...

if you add your queu log filename with *NO* events specified, you'll get the queue log rotated.
ie;

[logfiles]
;
;debug => debug
console => notice,warning,error
messages => notice,warning,error
queue_log =>

This will rotate your queue logs in the same fashon as it rotates your other log files when you type 'logger rotate' at the cli.  Happy Rotating :)
By: Frank Mandarino (fmandarino) 2004-05-05 08:17:12

For what it's worth, I have attached an updated patch which installs cleanly on the latest CVS version (CVS-HEAD-05/04/04-10:03:15), however, it now crashes Asterisk with a Segmentation violation, just after the agent accepts the call by pressing #.

Here is the backtrace:

Thread 1 (process 28663):
#0  0x40163b80 in strncpy () from /lib/i686/libc.so.6
#1  0x43c64b88 in queue_exec (chan=0x814fdb0, data=0x8152b70) at app_queue.c:658
#2  0x080734d8 in pbx_exec (c=0x814fdb0, app=0x81325e0, data=0x43fb774c, newstack=1) at pbx.c:424
#3  0x0807d835 in pbx_extension_helper (c=0x814fdb0, context=0x814fdb0 "SIP/204-123b", exten=0x815000c "9006423439", priority=44,
   callerid=0x8130e70 "\"Frank Mandarino\" <204>", action=135472608) at pbx.c:1206
#4  0x0807e0c9 in ast_pbx_run (c=0x81325e0) at pbx.c:1690
ASTERISK-1  0x0807c861 in pbx_thread (data=0x815000c) at pbx.c:1915
ASTERISK-2  0x4002c600 in pthread_detach () from /lib/i686/libpthread.so.0
By: Olle Johansson (oej) 2004-06-13 15:58:12

Any updates?
By: Malcolm Davenport (mdavenport) 2004-06-21 14:06:54

Closing.  Find me to open if there are any updates.