[Home]

Summary:ASTERISK-01383: [patch] Australian Indications
Reporter:ben_au (ben_au)Labels:
Date Opened:2004-04-09 10:41:13Date Closed:2004-09-25 02:51:25
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/Internationalization
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) indications.conf.sample.diff
Description:Australian ringtones and call progress indicators have been "not quite right" for a while.

I've found what they should be and tested 'em out. These sound just like the real thing! I don't know how to do the diff file thing, so I'll just post my findings here!

These would also need to be changed in zaptel's zonedata.c -- should I do another report for that (this is my first one ever!).

****** ADDITIONAL INFORMATION ******

Here is the verbose version of my indications.conf:

[au]
description = Australia
;
; Benjamin Wakefield (ben@team.dcsi.net.au) - April 9, 2004
; Tone definition source for AU was:
; Australian Communications Industry Forum/Standards Australia
; http://www.acif.org.au/__data/page/3303/S002_2001.pdf
;
; Normal Ring
ringcadance = 400,200,400,2000
; Distinctive Ring 1 - Forwarded Calls
ringcadance-dr1 = 400,400,200,200,400,1400
; Distinctive Ring 2 - Selective Ring 2 + Operator + Recall
ringcadance-dr2 = 400,400,200,2000
; Distinctive Ring 3 - Multiple Subscriber Number 1
ringcadance-dr3 = 200,200,400,2200
; Distinctive Ring 4 - Selective Ring 1 + Centrex
ringcadance-dr4 = 400,2600
; Distinctive Ring 5 - Selective Ring 3
ringcadance-dr5 = 400,400,200,400,200,1400
; Distinctive Ring 6 - Multiple Subscriber Number 2
ringcadance-dr6 = 200,400,200,200,400,1600
; Distinctive Ring 7 - Multiple Subscriber Number 3 + Data Privacy
ringcadance-dr7 = 200,400,200,400,200,1600
; Tones
dial = 400+425
busy = 425/375,0/375
; Ringtone for call to PSTN
ring = 400+425/400,0/200,400+425/400,0/2000
; Ringtone for calls to mobiles
ringmobile = 400+450/400,0/200,400+450/400,0/2000
; XXX Congestion: Should reduce by 10 db every other cadence XXX
congestion = 425/375,0/375,420/375,0/375
callwaiting = 425/200,0/200,425/200,0/4400
dialrecall = 400+425
; Record tone used for Call Intrusion/Recording or Conference
record = !425/1000,!0/15000,425/360,0/15000
info = 400/2500,0/500
; The STD "pips" indicate the call is not an untimed local call
std = !525/100,!0/100,!525/100,!0/100,!525/100,!0/100,!525/100,!0/100,!525/100
facility = 425
; Message Waiting "stutter" dialtone
stutter = 400+425/100,0/40



I've included Telstra's distinctive ring patterns as well. I know they're useless at the moment but it took a while to find official documentation so I though I'd include them anyway. They might be useful later.
Comments:By: Brian West (bkw918) 2004-04-09 21:44:21

Please attach a diff -u
By: ben_au (ben_au) 2004-04-11 01:48:36

I made a diff file! It looks a little different to others I've looked at (story of my life).

Hope it's okay. Sorry if I'm wasting anyones time, it's not on purpose.
By: adam (adam) 2004-04-15 21:07:38

perfect, it's exactly the same as firefly's ring - although I'm sure we modulated ours...

Tick of approval from me :)
By: ben_au (ben_au) 2004-04-16 00:13:01

The original note I said dialtone was 400+425... I've changed this to 413+438 -- so 425 sits in the middle (or as close as possible).

That applies to the ringtone as well.. so where you see 400+425 replace it with 413+438.

The patch file is right.

(I faxed in a disclaimer today)
By: veejoe (veejoe) 2004-04-16 02:53:13

I have tested this also, and in general thumbs are up.  One tiny thing to check: should info be "425/2500,0/500" instead of "400/2500,0/500"?

I like the use of a lower frequency in the second beat of the congestion tone (to simulate the 10dB attenuation that's supposed to be there).  ;)

Call waiting tone appears to be defined correctly, but is not being presented right on my phone (supposed to be "bip-bip", but only one "bip" comes out).  Don't think this is a problem with the proposed changes though.

I echo Benjamin's comment that matching changes need to be made in zaptel/zondata.c also.  Please advise if a separate bug report os required for this.
By: ben_au (ben_au) 2004-04-16 04:16:55

I've sent up another diff file, with the changes to the info tone, now it's consistent with everything else.

The call waiting bip-bip works okay for me, I thought it was so cute I sat listening to it for quite a while -- I had the "real" Telstra one in my other ear and it matches exactly!

The changes to zaptel/zonedata.c are being made over at 0001432
By: ben_au (ben_au) 2004-04-16 04:34:46

The change was the info tone. It was 400 now it's 425.
By: adam (adam) 2004-04-16 04:37:23

I love you all :) Bug Marshals, developers and testers coming together - it's a beautiful thing
By: Olle Johansson (oej) 2004-04-16 04:46:26

Adam - thank you :-)

I agree - it's a beautiful thing. And - it works!
By: Olle Johansson (oej) 2004-04-16 14:59:34

Mark - this one is ready for CVS now. /Olle
By: Olle Johansson (oej) 2004-04-16 17:39:34

All australians - check 1432 as well, please, and approve/disapprove.
By: Mark Spencer (markster) 2004-04-20 09:57:15

Fixed in CVS