Summary:ASTERISK-01334: [patch] manager.c uses portno= instead of port= config in manager.conf
Reporter:jht (jht)Labels:
Date Opened:2004-04-02 18:45:25.000-0600Date Closed:2004-09-25 02:18:19
Versions:Frequency of
Environment:Attachments:( 0) manager_port_portno.diff
( 1) manager_port.diff
Description:The manager.conf file included in the asterisk distribution has the line:
 port = 5038
It should read:
 portno = 5038
(bug reported by: chris ransom)


While the origional bug reported by jht/chris ransom is true, this is, more importantly, an inconstancy in the configs related to manager.c.  
Comments:By: twisted (twisted) 2004-04-02 23:26:46.000-0600

I have confirmed this is the case, and uploaded a diff to read the correct value from manager.conf as port=, so that we can unify some of the general settings in the .conf files for core applications.

Please note the only thing changed was reading the conf for value "portno" in "general" to read "port" in "general"

Please push this up to cvs, so we can clear this out.

edited on: 04-05-04 05:03

By: James Golovich (jamesgolovich) 2004-04-04 20:08:37

Should we error on the side of caution and allow either value?  Since the code has always been looking for portno, and the example config has always said port.

It would be very easy to support both, but I'm not sure if its the right thing to do

By: twisted (twisted) 2004-04-05 06:58:35

Good point.  I uploaded a patch (manager_port_portno.diff) to allow use of both, but log a notice to use port= instead of portno= .

edited on: 04-05-04 06:33

By: James Golovich (jamesgolovich) 2004-04-05 15:40:53

Fixed in CVS