Summary: | ASTERISK-01269: G.723.1 samples field value is wrong | ||
Reporter: | Paul Cadach (pcadach) | Labels: | |
Date Opened: | 2004-03-22 14:07:06.000-0600 | Date Closed: | 2011-06-07 14:11:56 |
Priority: | Trivial | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) codec_g723_1.c.diff | |
Description: | All other codecs uses samples as count of 1/8000 secs which is required to play out encoded fragment. But G.723.1 codec assumes samples field values specifies in milliseconds rather than in sampling ticks... | ||
Comments: | By: Brian West (bkw918) 2004-04-17 15:09:24 Whats the correct sample? By: Paul Cadach (pcadach) 2004-04-17 23:12:37 See description. Sample frames is correct, but calculation value of frame->samples field is wrong (currently it calculates as ms but must be in 1/8000 sec). By: Brian West (bkw918) 2004-04-17 23:21:45 can you supply a patch to fix this? By: Paul Cadach (pcadach) 2004-04-18 00:31:25 Something like this one... Just multiply all values used for calculation frame->samples field by 8 (i.e. samples per ms). By: Brian West (bkw918) 2004-04-19 16:34:49 this is in cvs-head already. bkw |