Summary:ASTERISK-01256: [patch] SIP disabled is LOG_ERROR
Reporter:Olle Johansson (oej)Labels:
Date Opened:2004-03-21 04:13:56.000-0600Date Closed:2004-09-25 02:48:26
Versions:Frequency of
Environment:Attachments:( 0) sipdisabled.txt
Description:Failure of loading the SIP channel is now reported with LOG_WARNING, I think it should be LOG_ERROR
Comments:By: James Golovich (jamesgolovich) 2004-03-24 22:25:55.000-0600

I can see changing the level on the failure of gethostbyname, but I think the non-existance of the config file should remain a warning or even be changed to a notice.

By: twisted (twisted) 2004-04-18 12:00:05

HouseKeeping - No real activity since 3-24-04

By: Olle Johansson (oej) 2004-04-18 14:57:00

Reminder to Olle to fix another patch and not be so stubborn :-)

By: Brian West (bkw918) 2004-04-18 16:57:16

Go no go? which is it?

By: Olle Johansson (oej) 2004-04-26 15:31:25

Looking at this again, I still think it should be an ERROR if the user wants to load a channel and the channel for some reason is not loaded.

By: Mark Spencer (markster) 2004-04-26 15:37:16

I'm not sure I understand why it should be ERROR vs. WARNING...  any explanation?

By: Olle Johansson (oej) 2004-04-26 15:39:50

If you think so, then remove the NOTICE... :-)

I think it's an error if a software is instructed to load a module and it doesn't load. We could add "If you do not want this module, add noload=<modulename> to modules.conf" to help the user.

By: Mark Spencer (markster) 2004-05-02 13:35:35

I've been really sparse in my use of ERROR to represent really critical failures which typically represent coding problems.  I don't think i'm going to change that behavior on here and in any case it doesn't strike me as particularly important.

What *is* important is that if you do a "reload" we should keep the old IP if we can't find the new hostname.  Otherwise a "reload" can cause SIP to silently stop working.