Summary:ASTERISK-01237: app_queue option "n" latches
Reporter:revk (revk)Labels:
Date Opened:2004-03-18 06:16:56.000-0600Date Closed:2004-09-25 02:18:20
Versions:Frequency of
Description:app_queue appears to set go_on when option 'n' is used. this appears to be global, and so once used it means all attempts to use Queue ever on any queue always operate as if option 'n' has been specified, making queuing unusable.


go_on appeasr to be treated differently than all of the other options for some reason, so I am wary of making a patch without fully understanding why.
Comments:By: Mark Spencer (markster) 2004-03-19 00:57:59.000-0600

Did you actually test this or is this a theory?  I looked at the code and there is nothing global about go_on, it's on the stack of each call.

By: revk (revk) 2004-03-19 06:07:43.000-0600

Yes, I found that having used Queue with 'n' option, it would apply to all later calls of Queue, hence looking at the code. The other options have tmp->whatever set, and it appears to be global. Using Fedora Core 1.

By: Brian West (bkw918) 2004-03-23 19:47:33.000-0600

i'm sorry but you are wrong, I have looked at this and have two queues setup one with option 'n' the other without.  It all works as expected.  Can you post your configs and we can look at what you mean exactly.

By: Mark Spencer (markster) 2004-03-24 16:59:38.000-0600

*puts bkw918's leash back on*

Do you have a way we can login to your system and watch this take place?  Nobody seems to be able to duplicate this bug, so we'll need to see it happen on your system or we'll just mark it as not a bug.

By: Mark Spencer (markster) 2004-03-31 14:24:15.000-0600

Okay, we really need to be able to login to your system to evaluate this.  We have been unable to duplicate this bug on our systems, with multiple people testing, so we need to get into your system or we'll have to close out the bug as unable to duplicate.  Please find me on irc, kram, irc.freenode.net, #asterisk.

By: revk (revk) 2004-04-02 07:28:26.000-0600

OK, I have just updated to the latest CVS and fine that app_queue has changed. The go_on variable is now local (passed as a pointer) and no longer a global, so I guess you have fixed it. Thanks.

Testing on latest CVS works as you would expect now.

Sorry for the delay replying - the emails were hitting my whitelist. I have whitelisted them now, so should be OK in future.

By: Mark Spencer (markster) 2004-04-02 10:48:22.000-0600

Fixed in CVS