[Home]

Summary:ASTERISK-01128: ParkedCall Event Generates Spurious Newline in Mgr Protocol
Reporter:jayson (jayson)Labels:
Date Opened:2004-03-01 14:56:00.000-0600Date Closed:2008-01-15 14:45:08.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) parkfix.patch
Description:When a parkedcall event comes through, there is an extra \r\n pair.  The parked call event in res/res_parking.c has a spurious newline (it provides one to the event that it doesn't need).


****** ADDITIONAL INFORMATION ******

Here's a simple patch:

ndex: res/res_parking.c
===================================================================
RCS file: /usr/cvsroot/asterisk/res/res_parking.c,v
retrieving revision 1.17
diff -u -r1.17 res_parking.c
--- res/res_parking.c   27 Feb 2004 06:15:49 -0000      1.17
+++ res/res_parking.c   1 Mar 2004 19:42:08 -0000
@@ -164,7 +164,6 @@
                                "From: %s\r\n"
                                "Timeout: %ld\r\n"
                                "CallerID: %s\r\n"
-                                "\r\n"
                                ,pu->parkingnum, pu->chan->name, peer->name
                                ,(long)pu->start.tv_sec + (long)(pu->parkingtime/1000) - (long)time(NULL)
                                ,(pu->chan->callerid ? pu->chan->callerid : "")
Comments:By: James Golovich (jamesgolovich) 2004-03-01 15:28:28.000-0600

Good catch... manager_event adds the extra \r\n for us.  I'll get this fixed up in CVS
By: James Golovich (jamesgolovich) 2004-03-01 15:43:45.000-0600

Fixed in CVS
By: Digium Subversion (svnbot) 2008-01-15 14:45:07.000-0600

Repository: asterisk
Revision: 2283

U   trunk/res/res_parking.c

------------------------------------------------------------------------
r2283 | citats | 2008-01-15 14:45:06 -0600 (Tue, 15 Jan 2008) | 2 lines

Remove extra
from manager event sent by res_parking.c (bug ASTERISK-1128)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2283
By: Digium Subversion (svnbot) 2008-01-15 14:45:08.000-0600

Repository: asterisk
Revision: 2284

U   branches/v1-0_stable/res/res_parking.c

------------------------------------------------------------------------
r2284 | citats | 2008-01-15 14:45:07 -0600 (Tue, 15 Jan 2008) | 2 lines

Remove extra
from manager event sent by res_parking.c (bug ASTERISK-1128)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2284