Summary:	ASTERISK-01119: [patch] Enhance sample.conf files to prevent common questions/errors
Reporter:	philipp2 (philipp2)	Labels:
Date Opened:	2004-02-27 19:04:45.000-0600	Date Closed:	2008-01-15 14:56:03.000-0600
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	Documentation
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) ext-diff ( 1) modemdiff ( 2) sample_config.txt ( 3) sipconfnew
Description:	extsions.conf.sample: - add more Dial examples for different technologies - add dial out examples for SIP providers like FWD sip.conf.sample: - include sample user entries for Grandstream and X-Lite modem.conf.sample: - add driver for i4l - set stripmsd=0 (with 1 it often gave headaches to new users)
Comments:	By: James Golovich (jamesgolovich) 2004-03-07 16:03:38.000-0600 Looks pretty good to me, but can you remove all the extra spacing changes?  Seems like a lot of the stuff is exactly the same except you remove the spacing For example, in sip.conf you change: port = 5060 to port=5060 By: philipp2 (philipp2) 2004-03-07 17:03:35.000-0600 So far things have not been consistent, we had both xxx = and xxx= sample config files. I prefer the one without space, and looking at the mailing list and other sample config files on the web this appears to me to be the preferred approach. By: James Golovich (jamesgolovich) 2004-03-07 17:16:12.000-0600 I think the best thing to do is leave it the way it is in each config file.  I like to see diffs as small as possible By: philipp2 (philipp2) 2004-03-07 17:26:17.000-0600 Well... can you bring forth a slightly more specific reason to leave things untouched here? One reason why I prefer the no-space version is that with callerid= things are a bit confusing: callerid=xxx yyy <123> callerid= xxx yyy <123> callerid = xxx yyy <123> callerid = "xxx yyy" <123> callerid = " xxx yyy <123>" Where does space matter, and where does it not? At least at first sight this isn't obvious. By: Olle Johansson (oej) 2004-04-06 14:14:00 The patch to extensions.conf and modem.conf is ok. But the sip.conf patch collides with current CVS head - update, please. And remove the space if we're shooting for CVS :-) By: philipp2 (philipp2) 2004-04-10 13:38:24 Ok, here it is, the revised sip.conf.sample. By: twisted (twisted) 2004-04-28 19:14:51 This is a great thing, but remove extra whitespacing in sip.conf diff.  Also, all 3 diffs fail against current cvs -head.  Please revise as necessary, and I think this would be a good thing. By: Mark Spencer (markster) 2004-04-29 01:13:21 If you can combine them into one nice good patch I'll put it in cvs head. By: Olle Johansson (oej) 2004-05-03 16:32:31 Added combined patch with small changes :-) By: Mark Spencer (markster) 2004-05-04 12:30:35 Unless I'm missing something, ASTERISK_PROMPT is an environment variable not in extensions.conf right?  In any case, we shouldn't change the default. By: Olle Johansson (oej) 2004-05-04 14:07:04 Embarrassing, didn't delete old file first... By: Olle Johansson (oej) 2004-05-06 14:29:32 Added relaxdtmf, realm, musicclass and language to sip.conf.sample (realm of course depends on the approval of a separate patch for realm config in chan_sip...) By: Olle Johansson (oej) 2004-05-06 16:57:23 Updated for current CVS head By: Mark Spencer (markster) 2004-05-06 23:54:50 A few cleanups I'd like to see: In SIP: host doesn't apply to a user, only to a peer.  In general, the use of "users" in SIP is rarely necessary.  It might be worthwhile for us to support "callerid", "accountcode", "amaflags", "incominglimit", "outgoinglimit", and "restrictcid" based on peers as well. "language" is misspelled as "langauge" at one point modem.conf does not configure the internet phone jack at all, that's a typo. extensions: you have 6475 instead of 6275 at two locations in the file Other than that, looks good. By: Mark Spencer (markster) 2004-05-06 23:55:46 Oh yah, and "host=" is not valid for a user. By: Mark Spencer (markster) 2004-05-16 14:06:35 localnet syntax has changed....  is there a unified patch? By: Mark Spencer (markster) 2004-05-23 21:54:25 seems to have died... By: Olle Johansson (oej) 2004-05-24 03:15:37 New patch added. By: Mark Spencer (markster) 2004-05-24 10:55:49 Added to CVS By: Digium Subversion (svnbot) 2008-01-15 14:56:03.000-0600 Repository: asterisk Revision: 3057 U   trunk/configs/extensions.conf.sample U   trunk/configs/modem.conf.sample U   trunk/configs/sip.conf.sample ------------------------------------------------------------------------ r3057 | markster | 2008-01-15 14:56:03 -0600 (Tue, 15 Jan 2008) | 2 lines Improve sample configuration files (bug ASTERISK-1119) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3057