[Home]

Summary:ASTERISK-01083: Return before spin_unlock - found in code review
Reporter:woofie (woofie)Labels:
Date Opened:2004-02-23 21:34:50.000-0600Date Closed:2008-06-07 10:36:08
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Code review of zaptel.c found, CVS version - last night

line 3206 :  return -EBUSY;

however, code is in a spin_lock_irqsave(&chan->lock, flags) call.



****** ADDITIONAL INFORMATION ******


Granted, the if condition is highly unlikely it would ever happen, but if it did, might be a problem.

recommend replace line 3206 with something like
                          {
                             rv = -EBUSY;
                             break;
                          }

sorry, do not have time for patch. Not sure if my answer is correct anyway, been a while since C programming.
Comments:By: James Golovich (jamesgolovich) 2004-02-27 00:31:15.000-0600

Fixed in CVS.  Good catch, keep em coming.
By: Digium Subversion (svnbot) 2008-06-07 10:36:08

Repository: dahdi
Revision: 320

U   trunk/zaptel.c

------------------------------------------------------------------------
r320 | citats | 2008-06-07 10:36:07 -0500 (Sat, 07 Jun 2008) | 2 lines

Return before spin_unlock (bug ASTERISK-1083)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=320