Summary:ASTERISK-01069: CALLERIDNUM strips the dots
Reporter:ktsaou (ktsaou)Labels:
Date Opened:2004-02-20 21:00:58.000-0600Date Closed:2011-06-07 14:10:28
Versions:Frequency of
Environment:Attachments:( 0) callerid.txt
Description:Fully qualified SIP addresses normally contain a dot in their domain part. However the variable CALLERIDNUM strips the dots (among other things, in callerid.c/ast_shrink_phone_number(), line 500), making useless.

I have verified this while trying to use the contents of this variable with DBGet/DBPut.

Please see also patch http://bugs.digium.com/bug_view_page.php?bug_id=0001074 that allows fully qualified SIP addresses to be used by asterisk.
Comments:By: ktsaou (ktsaou) 2004-02-21 04:58:29.000-0600

By simply removing the dot from this line:

if (!strchr("( )-.", n[x]))

fixes the problem.

By: zoa (zoa) 2004-02-21 06:05:09.000-0600

ktsaou, can you give us a diff -u ?

(and please upload the filename as a .diff.txt to make it easier for us to browse it in internet exploder.)

By: zoa (zoa) 2004-02-25 06:20:06.000-0600

Reminder sent to ktsaou

By: ktsaou (ktsaou) 2004-02-25 14:15:07.000-0600

I already have done it, 2 hours and 21 minutes after you asked for it... :)
The name is wrong though. It should be named: callerid.c.diff.txt
Sorry for this.

By: Mark Spencer (markster) 2004-03-04 19:20:46.000-0600

The IP address is not the phone number.  The portion in the <> within asterisk *is* the phone number.

By: ktsaou (ktsaou) 2004-03-04 20:56:56.000-0600

I guess you mean SIP not IP address.

CallerID is technology specific. For SIP, IAX, etc it is not necesserily a number, and to be more precise, a number alone cannot be a fully qualified callerid for these technologies.

Anyway, ingore the patch. Please also ignore/close bug 1074 that requires this.