[Home]

Summary:ASTERISK-01063: Changing password on a voicemail box changes it on all same-numbered boxes on all contexts
Reporter:Ryan Tucker (rtucker)Labels:
Date Opened:2004-02-20 15:06:29.000-0600Date Closed:2008-01-15 14:44:21.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail.c.patch.txt
( 1) app_voicemail.c.patch2.txt
Description:Greetings...

We have voicemail partitioned such that we have the same extension set shared across multiple contexts.  e.g.:

[customer-one]
100 => 1234,Receptionist,...
101 => 1234,Dirk Winchester,...

[customer-two]
100 => 1234,Receptionist,...
etc, etc

If someone changes the password for, say, 100@customer-two, it'll also change 100@customer-one (and any other 100's as well).  This is a bit of a problem.

We're using flat voicemail.conf currently; not adverse to moving to pgsql, but I figure a bug is a bug.  :-)  -rt
Comments:By: Rob Gagnon (rgagnon) 2004-02-23 16:55:06.000-0600

[patch] uploaded should solve your problem.  

vm_change_password() function changed to track the name of the context as file is parsed so that only the matching combination of user, pass, and context is changed.

By: James Golovich (jamesgolovich) 2004-02-23 17:10:33.000-0600

can the patch get modified so the variable names are more uniform like the rest of the code?

By: Rob Gagnon (rgagnon) 2004-02-23 17:14:39.000-0600

actually I was hoping to start some kind of naming convention... :-)

prefix:  sz = character string
psz = pointer to character string

etc....

maybe wrong time to start this?  :-)

patch2 is same patch, but with existing messy naming convention :-)

edited on: 02-23-04 16:02

By: Rob Gagnon (rgagnon) 2004-02-24 12:15:06.000-0600

Reminder sent to markster

[patch] created to resolve this bug... Can you take a look?

By: Mark Spencer (markster) 2004-02-24 12:23:13.000-0600

Fixed in CVS

By: Digium Subversion (svnbot) 2008-01-15 14:44:21.000-0600

Repository: asterisk
Revision: 2228

U   branches/v1-0_stable/apps/app_voicemail.c

------------------------------------------------------------------------
r2228 | markster | 2008-01-15 14:44:21 -0600 (Tue, 15 Jan 2008) | 2 lines

Handle change password properly with multiple VM contexts (bug ASTERISK-1063)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2228

By: Digium Subversion (svnbot) 2008-01-15 14:44:21.000-0600

Repository: asterisk
Revision: 2227

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r2227 | markster | 2008-01-15 14:44:20 -0600 (Tue, 15 Jan 2008) | 2 lines

Handle change password properly with multiple VM contexts (bug ASTERISK-1063)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2227