| Summary: | ASTERISK-01037: "codec0 is not codec1" bug in ast_rtp_bridge | ||
| Reporter: | exomorph (exomorph) | Labels: | |
| Date Opened: | 2004-02-16 15:41:28.000-0600 | Date Closed: | 2008-01-15 14:43:51.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | From my log, below, you will see that ast_rtp_bridge is not comparing the codecs properly. Asterisk is currently comparing the integers, and not the bits of the codec. In the below example codec0 = 260. That means Codec0 allows both 256 (g729) and 4 (uLaw). So that would mean that Codec0 and Codec1 do have a "Codec Match". Asterisk needs to do a bit compare, and not a int compare in this case. ****** STEPS TO REPRODUCE ****** Have one system support 2 codecs (say G729 and uLaw) and another only support one of those (say g729). When making a call, it will not bridge the call because Asterisk does not see a "codec match". ****** ADDITIONAL INFORMATION ****** -- SIP/dialnet-8bac answered SIP/chris0-df00 -- Attempting native bridge of SIP/chris0-df00 and SIP/dialnet-8bac Feb 16 11:27:48 WARNING[68889520]: rtp.c:1204 ast_rtp_bridge: codec0 = 260 is not codec1 = 256, cannot native bridge. Feb 16 11:27:50 NOTICE[68889520]: rtp.c:264 process_rfc3389: RFC3389 support incomplete. Turn off on client if possible Feb 16 11:27:50 NOTICE[68889520]: rtp.c:293 process_rfc3389: Don't know how to handle RFC3389 for receive codec 256 | ||
| Comments: | By: Mark Spencer (markster) 2004-02-18 16:51:58.000-0600 Fixed in CVS By: Digium Subversion (svnbot) 2008-01-15 14:43:51.000-0600 Repository: asterisk Revision: 2192 U trunk/rtp.c ------------------------------------------------------------------------ r2192 | markster | 2008-01-15 14:43:51 -0600 (Tue, 15 Jan 2008) | 2 lines Fix comparision in RTP native bridge (bug ASTERISK-1037) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=2192 By: Digium Subversion (svnbot) 2008-01-15 14:43:51.000-0600 Repository: asterisk Revision: 2191 U branches/v1-0_stable/rtp.c ------------------------------------------------------------------------ r2191 | markster | 2008-01-15 14:43:50 -0600 (Tue, 15 Jan 2008) | 2 lines Fix comparision in native bridge RTP (bug ASTERISK-1037) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=2191 | ||