Summary:ASTERISK-01032: [post-1.0][patch] IAX2 not passing caller*id presentation indicator / ast_channel restrictcid-flag not set
Reporter:flying_sushi (flying_sushi)Labels:
Date Opened:2004-02-16 05:35:53.000-0600Date Closed:2004-10-01 23:11:36
Versions:Frequency of
Environment:Attachments:( 0) chan_iax2.restrictcid[1].patch
( 1) chan_mgcp.c-restriccid.patch
( 2) iax2-callingpres-and-restrictcid-patch.patch
Description:Have two asterisk systems running connected to each other via IAX2, one of them is connected to the PSTN via E410P card. When dialing in from PSTN to asterisk via E410P/Zap channel and passing the call via IAX2 to the second *-system, the caller*id presentation indicator is not passed to the second asterisk system (restrictcid flag is not set within the ast_channel structure). even when caller*id presentation restriction is activated by the calling party, the caller*id is being transmitted to the called party. this is a serious security issue.


I'll have a patch ready this week.
Comments:By: zoa (zoa) 2004-02-16 13:19:10.000-0600

flying_sushi, did you also say something on #asterisk about the congestion value not being passed ?

By: Brian West (bkw918) 2004-02-16 15:20:10.000-0600

that was fixed if I recall.

By: zoa (zoa) 2004-02-17 05:01:21.000-0600

i think only the congestion/busy logging/passing from zaptel was fixed, (eg the logging in the cdr and hangupcause vars, not the passing of the variable in the iax2 code).

By: flying_sushi (flying_sushi) 2004-02-19 00:57:23.000-0600

i've added a patch for chan_iax2.c to set/transfer the restrictcid flag to the remote *-system and a patch for chan_mgcp.c to support the restrictcid flag. typing "show channel" on the console will display the callerid even when restricted, when 'restrictcid'-flag is on, the callerid will not be passed to the remote endpoint.

By: Brian West (bkw918) 2004-04-18 01:50:49

Please post updated patches for this!??!?!?

By: flying_sushi (flying_sushi) 2004-04-27 10:28:41

i've added the 'RESTRICTCID.PATCH'. this file updates iax2.h, iax2-parser.h, iax2-parser.c, and chan_iax2.c to support the restrictcid flag.

edited on: 04-27-04 09:23

By: Mark Spencer (markster) 2004-05-02 13:59:36

Do you think we should support the full range of PRI callerid restriction flags?

By: flying_sushi (flying_sushi) 2004-05-03 08:48:37

hmm, not sure about that, if we might go a little further towards the future where ISUP/ISDN-over-SIP is beeing introduced/widely adopted, than we might need the full range, on the other side it might be sufficient to leave it as is and only use simple restriction. I'll leave this decision up to you.

By: twisted (twisted) 2004-06-16 23:20:25

can we get an update?

By: flying_sushi (flying_sushi) 2004-06-21 04:07:34

an update?

By: flying_sushi (flying_sushi) 2004-07-16 07:12:01

the latest patch (iax2-callingpres-and-restrictcid-patch) also includes the callingpres-value.

what do i have to do to make it into the source tree? markster, everytime i do a cvs co i also have to update/apply the patch and test it over and over again, it's just annoying. please, can we do something about that?

By: Brian West (bkw918) 2004-07-16 23:03:41

can we get an update on this ASAP

By: Mark Spencer (markster) 2004-07-16 23:10:44

What's the difference between restrict CID and presentation?

By: flying_sushi (flying_sushi) 2004-07-19 04:30:31

good question. hmm... callingpres can be used to indicate more than just one state. you may use it to indicate whether or not the caller*id may be presented and/or whether the number is authorized and what authority was used verify the number. actually, this feature is quite usefull when using asterisk as a pstn-voip-pstn bridge.

By: Mark Spencer (markster) 2004-10-01 22:11:07

Added to CVS

By: Russell Bryant (russell) 2004-10-01 23:11:36

not included in the 1.0 branch - feature