[Home]

Summary:ASTERISK-01016: [patch] RemoveQueueMember & AddQueueMember problems
Reporter:ac931274 (ac931274)Labels:
Date Opened:2004-02-10 08:14:48.000-0600Date Closed:2004-09-25 02:17:33
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.diff
( 1) app_queue.diff
Description:If you call the above cmds and the user is already in that state it returns -1
This patch to current CVS will jump to exten + 101 (if exists) instead otherwise returns -1

****** ADDITIONAL INFORMATION ******

--- /tmp/csv/asterisk/apps/app_queue.c  2004-02-04 19:42:18.000000000 +0000
+++ /usr/src/asterisk/apps/app_queue.c  2004-02-10 11:38:54.000000000 +0000
@@ -990,8 +990,15 @@
                                       res = 0 ;
                               }
                               else
+                               {
                                       ast_log(LOG_WARNING, "Unable to remove interface '%s' from queue '%s': "
                                               "Not there\n", interface, queuename);
+                                       if (ast_exists_extension(chan, chan->context, chan->exten, chan->priority + 101, chan->callerid))
+                                               {
+                                               chan->priority += 100;
+                                               res = 0 ;
+                                               }
+                               }
                       }

                       ast_mutex_unlock(&q->lock);
@@ -1070,8 +1077,15 @@
                                       res = 0 ;
                               }
                               else
+                               {
                                       ast_log(LOG_WARNING, "Unable to add interface '%s' to queue '%s': "
                                               "Already there\n", interface, queuename);
+                                       if (ast_exists_extension(chan, chan->context, chan->exten, chan->priority + 101, chan->callerid))
+                                        {
+                                                chan->priority += 100;
+                                                res = 0 ;
+                                        }
+                               }
                       }

                       ast_mutex_unlock(&q->lock);
Comments:By: Brian West (bkw918) 2004-02-10 12:05:40.000-0600

do my bad I ment diff -u haha slight typo on my part sorry
By: Brian West (bkw918) 2004-02-10 12:27:59.000-0600

we want the diff attached we will not copy and paste it out of the bug notes.  Just in case its invalid or wrong we won't waste time trying to fix a bogus patch.
By: ac931274 (ac931274) 2004-02-10 17:34:17.000-0600

There you go.

Jonathan
By: Brian West (bkw918) 2004-04-17 23:42:41

I wanna see this ASAP have you sent a disclaimer?
By: ac931274 (ac931274) 2004-04-18 06:04:11

I will Fax it to you on Monday.
By: James Golovich (jamesgolovich) 2004-04-19 03:01:26

If this is going to be added the description needs to be updated to reflect the new behavior
By: ac931274 (ac931274) 2004-04-19 09:23:21

Disclaimer sent by fax
By: ac931274 (ac931274) 2004-04-19 14:28:41

Description changed and uploaded
By: Brian West (bkw918) 2004-04-26 02:46:20

yay I would love to see this added ASAP
By: James Golovich (jamesgolovich) 2004-04-26 02:53:24

Commited to CVS HEAD