Summary:ASTERISK-01001: [patch] Recognise distinctive ring when presented after CID
Reporter:veejoe (veejoe)Labels:
Date Opened:2004-02-06 06:22:11.000-0600Date Closed:2011-06-07 14:10:29
Versions:Frequency of
Environment:Attachments:( 0) bug1007-dist_ring_after_cid.patch.txt
( 1) dist_ring_after_cid.patch
Description:My telco (Telstra, Australia) does not modify the ring cadence for distinctive ring until after the CID data is presented.  This confuses chan_zap, as the code is designed to pick up the distinctive ring cadence prior to the CID data being received.  Therefore, distinctive ring is broken for this situation.


I have written a patch to enter another loop of ring detection after the CID is picked up (under the control of a parameter "distinctiveringaftercid" in zapata.conf).  I think it's pretty ugly but it works for me.  I'd like to know if I'm going about this the right way though.
Comments:By: veejoe (veejoe) 2004-02-06 06:27:36.000-0600

Sorry, I'm rusty at building patch files...  Patch needs to applied in the asterisk/channels directory (but just looking at it will tell what's happening).

By: duane (duane) 2004-04-15 21:59:22

Doesn't patch cleanly to current CVS (-head)

By: Matt Riddell (zx81) 2004-05-02 13:06:38

Would be interested in this patch also...anyway of getting it to patch against stable or head?

By: twisted (twisted) 2004-05-02 22:52:37

Basically we need someone to re-write this to clean this up and make it patch agains -head.  If you really want to see this in, I suggest getting it done :)

By: alric (alric) 2004-05-05 15:26:48

Is someone actively working on twisted's suggestions?  Do you have a progress update?

By: sbingner (sbingner) 2004-05-07 04:29:13

Modified to apply to cvs if anybody wants to see if it still works -- I can't test since I don't have a flakey telco... but it dosn't crask * yet! ;)

By: twisted (twisted) 2004-06-17 00:03:00

Can someone test this to see if it works?

By: twisted (twisted) 2004-07-01 16:52:06

Closed due to lack of interest.

By: deon (deon) 2004-07-07 08:33:54

Reminder sent to twisted

I was trying to figure out how to re-open this - I'm happy to test this - I'm in Australia and I just got my telco to turn on CID and distinctive ring (and I'd like to get this to work, so that I can have * do different things depending on the incoming call).

I'll try the patch file and give you feedback if you are still interested.

By: deon (deon) 2004-07-07 09:16:42

Reminder sent to twisted

Woo hoo it works!

OK, I had to modify the patch to get it to patch with the CVS I'm using (2004-06-17) - if you would like it, then just drop me a mail.

Here is the evidence:
Asterisk Ready.
*CLI>     -- Starting simple switch on 'Zap/1-1'
   -- Detecting post-CID distinctive ring
Jul  7 23:52:18 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
Jul  7 23:52:19 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
Jul  7 23:52:21 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
   -- Detected ring pattern: 265,235,115
   -- Distinctive Ring matched context zap-caller
   -- Hungup 'Zap/1-1'
   -- Starting simple switch on 'Zap/1-1'
   -- Detecting post-CID distinctive ring
Jul  7 23:53:08 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
Jul  7 23:53:08 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
Jul  7 23:53:09 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
Jul  7 23:53:11 NOTICE[-1211024464]: chan_zap.c:5026 ss_thread: Got event 2 (Ring/Answered)...
   -- Detected ring pattern: 275,245,215
   -- Checking 265,235,115
   -- Checking 275,245,215
   -- Distinctive Ring matched context distr-caller
   -- Hungup 'Zap/1-1'
Urgent handler
Urgent handler

By: Michael Jerris (mikej) 2005-06-05 23:28:00

veejoe, can you confirm that this patch was disclaimed.  We have several people calmoring for it now.

By: Michael Jerris (mikej) 2005-06-05 23:28:47

Lets leave this one open for a few days and see if we can verify the disclaimer.

By: Jason Lingohr (jsl) 2005-06-05 23:36:37

I've also tested this patch and it is working fine (perhaps ringing for a bit too long now, but works), and am very keen for veejoe to resurface.

By: Michael Jerris (mikej) 2005-06-19 13:37:50

well, 2 weeks no answer.  If somone can either re-code this themsleves so it can be disclaimed, or verify the original disclaimer, we will reopen this.

By: veejoe (veejoe) 2005-06-19 17:56:20

Sorry everyone -- been away from email a while.  Could someone please send me a private note or post a link to tell me what I need to do.

By: veejoe (veejoe) 2005-06-19 17:59:29

S'ok, I found the disclaimer stuff -- will try and get something worked out (faxing is a PITA for me, international even worse :)   Sorry for the noise.

By: Michael Jerris (mikej) 2005-06-19 18:02:35

well... first off, can you verify if you have sent a disclaimer to digium, and if not, can you please send them one.  You can find information on the disclaimers at bugs.digium.com in the bug guidelines.  After that we need the patch updated for current cvs head and some people to comment that it is working.  Welcome back!

By: Michael Jerris (mikej) 2005-06-23 23:23:49

You can e-mail a scanned copy of the signed disclaimer too kpfleming@digium.com.  Thanks.

By: deon (deon) 2005-06-23 23:28:21

veejoe - I'll happily test the new patch if you provide a new one... (TDM's are now A-ticked, so I can test it legally :)

(The last patch I submitted (which just reworked yours) worked fine - its either on this bug number or 0003596).

By: Michael Jerris (mikej) 2005-07-11 22:59:04

veejoe-  did you ever get a disclaimer filed?  Can we please get this updated to newest head.

By: Michael Jerris (mikej) 2005-07-20 18:58:15

suspended once again due to lack of response.  This can be re-opened once a disclaimer is filed.