Summary:ASTERISK-00992: linux Kernels now using CONFIG_SMP instead of __SMP__ in Makefiles
Reporter:woofie (woofie)Labels:
Date Opened:2004-02-04 19:25:13.000-0600Date Closed:2004-09-25 02:53:50
Versions:Frequency of
Description:Have noticed the -D__SMP__ in zaptel makefile. Upon review of my linux 2.4.20-28.9 kernel source seems to primarily use CONFIG_SMP.  Since I am running an smp system, I am not sure, but the uncomment of the -D__SMP__ in the zaptel makefile is probably not doing what it was originally intended to do. I am not too sure of this. This may warrent some investigation by folks who know what the -D__SMP__ in the zaptel routines is supposed to do?


traced down some includes

modules.h includes spinlock.h which uses CONFIG_SMP define

usb.h seems to include interrupt.h which uses CONFIG_SMP define

I have no idea if this is going to make a difference or not
Comments:By: woofie (woofie) 2004-02-04 20:01:43.000-0600

Actually traced down more.  
I think this was not an issue in my implementation.

Seems the linux/config.h file includes the linux/autoconf.h which has the CONFIG_SMP define inside there.

Still not sure then why the -D__SMP__ define for zaptel makefile

By: zoa (zoa) 2004-02-24 08:15:34.000-0600

krambo, what do you think about this ?

By: James Golovich (jamesgolovich) 2004-02-28 03:39:11.000-0600

I was curious on this myself so I started looking and it looks like defining __SMP__ isn't going to do anything at all.  The important define happens like woofie said in linux/autconf.h.  So assuming all of the linux/* headers we include also include linux/config.h (which includes autoconf.h) then we should be good.  I checked all the headers that contain CONFIG_SMP that we use and they all include config.h so we should be ok.

There are a few that don't include config.h, but they should be ok.  I think we should remove the line from the Makefile

By: James Golovich (jamesgolovich) 2004-03-20 03:09:51.000-0600

I removed the reference to __SMP__ from the Makefile since it definitely doesn't do anything anymore.  bug closed