[Home]

Summary:ASTERISK-00982: Tab completion displays incorrect completions
Reporter:gcc (gcc)Labels:
Date Opened:2004-02-03 09:06:17.000-0600Date Closed:2008-01-15 15:14:17.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) bleh.txt
Description:Typing "iax<tab>" at the CLI displays the following top-level commands:

iax1  iax2

i.e. "iax" by itself is not a complete command. However, typing a space and pressing <tab> displays:

debug  no     set    show   debug  no     set    show   trunk

This cannot be right because there are no valid commands under "iax". Typing the first letter of any of these commands and pressing <tab> displays no completions anymore.
Comments:By: Tilghman Lesher (tilghman) 2004-02-03 10:18:29.000-0600

It isn't iax specifically.  If you type "s <tab>", you'll get possible completions, as well.  I suspect that the CLI is only comparing the first argument for a possible match before comparing the second argument, not comparing the first argument for a full match before showing the results for the second match.

Probably the place to look is inside __ast_cli_generator() in cli.c.
By: James Golovich (jamesgolovich) 2004-02-14 16:31:28.000-0600

I'll commit a fix for this when I grab my laptop out of the car later today.
By: James Golovich (jamesgolovich) 2004-02-15 01:15:06.000-0600

Fixed in cvs
By: Jeffrey C. Ollie (jcollie) 2004-11-17 09:47:41.000-0600

junky wants to make a comment
By: Clod Patry (junky) 2004-11-17 11:49:00.000-0600

i was playing around the show application

asterisk*CLI> show application Di<tab>
Dial          DialConfirm   DigitTimeout  Directory     DISA
asterisk*CLI> show application D<tab>
DateTime      DBdel         DBdeltree     DBget         DBput         DeadAGI       Dial          DialConfirm
DigitTimeout  Directory     DISA          DumpChan      DUNDiLookup
asterisk*CLI> show application D

it's like it's skipping the "i" from the first Di.


I've the same behavior for the:
asterisk*CLI> show application Ag
AgentCallbackLogin    AgentLogin            AgentMonitorOutgoing  AGI
asterisk*CLI> show application A
its skipping the "g"

but i've no trouble with the :
asterisk*CLI> show application DB
DBdel      DBdeltree  DBget      DBput
asterisk*CLI> show application DB

I'll take a look in the completion, but until now, i didn't find how to fix this. If anyone can fix, go ahead.

P.S. that happens on the the version: CVS-HEAD-11/16/04-09:45:01.
By: Mark Spencer (markster) 2004-11-17 23:11:10.000-0600

Fixed in CVS
By: Russell Bryant (russell) 2004-11-17 23:16:39.000-0600

fixed in 1.0 - will be in 1.0.3
By: Digium Subversion (svnbot) 2008-01-15 14:43:27.000-0600

Repository: asterisk
Revision: 2163

U   trunk/cli.c

------------------------------------------------------------------------
r2163 | citats | 2008-01-15 14:43:27 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix command completion (bug ASTERISK-982)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2163
By: Digium Subversion (svnbot) 2008-01-15 14:43:28.000-0600

Repository: asterisk
Revision: 2164

U   branches/v1-0_stable/cli.c

------------------------------------------------------------------------
r2164 | citats | 2008-01-15 14:43:28 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix command completion (bug ASTERISK-982)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=2164
By: Digium Subversion (svnbot) 2008-01-15 15:14:16.000-0600

Repository: asterisk
Revision: 4287

U   trunk/cli.c

------------------------------------------------------------------------
r4287 | markster | 2008-01-15 15:14:16 -0600 (Tue, 15 Jan 2008) | 2 lines

Minor command completion tweak (bug ASTERISK-982 bis)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4287
By: Digium Subversion (svnbot) 2008-01-15 15:14:17.000-0600

Repository: asterisk
Revision: 4288

U   branches/v1-0/cli.c

------------------------------------------------------------------------
r4288 | russell | 2008-01-15 15:14:17 -0600 (Tue, 15 Jan 2008) | 2 lines

fix tab completion issue (bug ASTERISK-982)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4288