Summary:ASTERISK-00925: [patch] Various minor fixes
Reporter:mman (mman)Labels:
Date Opened:2004-01-27 11:46:32.000-0600Date Closed:2008-01-15 14:42:23.000-0600
Versions:Frequency of
Environment:Attachments:( 0) various2.patch
Description:Just some minor fixes. Proper "getopt" handling in "main()" (current handling doesn't work in some platforms, e.g. arm-linux). Hide stuff that should be printed. Add a "parking reload" command.
Comments:By: Brian West (bkw918) 2004-01-27 12:00:55.000-0600

Can you give a play by play on these changes?  Ie the format_g729 why are you changing from 20 to 10 and such?  (also thanks the parking reload was needed :)  )

By: Brian West (bkw918) 2004-01-27 12:05:41.000-0600

Also while your digging around in parking... let me relay the idea on how it should be done.  We need to dynamically allocate parking slots.  Also have the ability to virtualize it.  Right now we have one shared parking lot.  If you use asterisk in a virualized setup its not very flexable in that case.

By: Olle Johansson (oej) 2004-01-27 12:33:55.000-0600

I would prefer if the "various" fixes was split up in several patches, so we could feedback one by one. The current topic doesn't attract testers... I don't know if this patch is messing around in an area I'm working on or not...

By: Olle Johansson (oej) 2004-01-27 12:35:42.000-0600

"Reload prking conf info"

prking -> parking


By: Brian West (bkw918) 2004-01-27 12:43:20.000-0600

Reloading on the parkign pos doesn't work because just changing the pos in the file doesn't remove old parking positions and create new ones.  The ability to reload the config and change the parking timeout is nice but thats about all the parking reload can do at this time. Reload can only change the parking timeout.  Remove the other cruff and it will be good.

By: mman (mman) 2004-01-27 12:47:47.000-0600

The changes in "indications.c", "apps/app_qcall.c", "apps/app_queue.c",
"pbx/pbx_spool.c", "pbx/pbx_wilcalu.c" hide some messages that normally
shouldn't be printed (most of them are noticable when you start asterisk
as "asterisk -c"). Nothing special about them.

The change in "asterisk.c" is quite important. In an arm-linux platform
asterisk stays forever in the getopt while-loop because of the termination
condition ( != EOF). This should be ( != -1), per getopt man page.

The "parking reload" was missing and I thought it should be there.

By: mman (mman) 2004-01-27 12:51:21.000-0600

About "formats/format_g729.c":
G.729 frames are 10 bytes long.
Why should asterisk read multiples of 20?

By: mman (mman) 2004-01-27 13:00:33.000-0600

you are right about the parking part.
I'll fix that later.
I attach the same file without the parking patch (various2.patch).

By: jrollyson (jrollyson) 2004-01-27 21:50:45.000-0600

Also, is this disclaimed? ;)

By: Mark Spencer (markster) 2004-01-28 15:40:42.000-0600

Fixed in CVS

By: Digium Subversion (svnbot) 2008-01-15 14:42:23.000-0600

Repository: asterisk
Revision: 2087

U   trunk/apps/app_qcall.c
U   trunk/apps/app_queue.c
U   trunk/asterisk.c
U   trunk/formats/format_g729.c
U   trunk/indications.c
U   trunk/pbx/pbx_spool.c
U   trunk/pbx/pbx_wilcalu.c

r2087 | markster | 2008-01-15 14:42:22 -0600 (Tue, 15 Jan 2008) | 2 lines

Various minor cleanups (bug ASTERISK-925)