Summary:	ASTERISK-00890: [patch] IAX2 on-the-fly codec choosing and inbound codec fix
Reporter:	Anthony Minessale (anthm)	Labels:
Date Opened:	2004-01-21 14:37:12.000-0600	Date Closed:	2011-06-07 14:10:20
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_iax2.c.diff ( 1) chan_iax2.c.diff ( 2) chan_iax2.c.diff
Description:	Patch does 2 things: 1) lets you override the codec in the dial string with codec%host syntax IAX2/gsm%mybox/1234 2) when you define a peer in iax.conf   and someone calls you from that peer   it will obey the codec settings from THAT   peer not the last-added one like before
Comments:	By: Brian West (bkw918) 2004-01-22 13:28:12.000-0600 I think we need to pick out ${IAX_CODEC} similar to how chan_sip does it with SIP_CODEC. bkw By: Anthony Minessale (anthm) 2004-01-22 19:58:34.000-0600 I looked up  SIP_CODEC and that one looks like it pertains to inbound calls this patch is for outbound dialstrings so the other one can still be implemented too also in the new version I fixed the notransfer option being ignored. By: Mark Spencer (markster) 2004-01-23 10:05:01.000-0600 How about IAX_CODEC_OUT variable?  We'll also be changing SIP_CODEC to two separate SIP_CODEC_IN and SIP_CODEC_OUT variables. By: Mark Spencer (markster) 2004-01-23 10:06:54.000-0600 Also, create_addr should be used to populate the capability, not separately with the get_peer_by_host or whatever. By: Anthony Minessale (anthm) 2004-01-24 11:00:39.000-0600 ok , I just added that get_peer cos there seemed to be no way to find it from that scope maybe if a pointer to it was availabe cos no consideration for the peer's settings seem to play a role on inbound calls. My way is for sure a hack meant to fix my issue in 1 day and I'm open to the right way to get the same effect where the capability of the peer you are making the call from as defined in your iax.conf is honored on inbound calls and so you can choose a capibility on outbound calls. also my existing version had a bug fixed by the most recend uploaded file all others should be nuked. By: Olle Johansson (oej) 2004-03-21 15:35:35.000-0600 Seems like this patch is not approved and we need another piece of code to fix the problem, adding a IAX_CODEC_OUT variable. By: heison (heison) 2004-03-21 16:55:15.000-0600 does this work with the current CVS? and what happens if the receiving side 'DOES NOT' support the specify codec? Does it then negotiates others? By: Mark Spencer (markster) 2004-04-10 21:10:15 I'm willing to take the IAX_CODEC_OUT portion but with IAX, the selection of friend/user is based on the specified user name and NEVER has ANYTHING to do with the calling IP and WILL NOT have anything to do with the calling IP.  That's another broken misfeature of the SIP model that is not making it into IAX. By: zoa (zoa) 2004-04-11 14:25:49 would this allow me to enfore pass thru mode ? eg: i would like to dial with asterisk 1 to asterisk 2 using ilbc, and asterisk 2 will forward this call to asterisk 3. i'd like asterisk 2 to allow all incoming codecs, and reuse this codec when forwarding the call to asterisk 3. Currently it will select the preferred codec of the asterisk2-3 peer. Maybe i can already do this now with some magic ? By: Mark Spencer (markster) 2004-04-12 11:22:54 We already do this right with SIP, and with IAX2 we could do the same thing and set the preferred codec to be what we called with, if it was permitted.  But yes, this would allow you complete control even above and beyond that. By: Anthony Minessale (anthm) 2004-04-12 21:44:13 this bug is junk, forget it existed. By: Anthony Minessale (anthm) 2004-04-12 21:45:44 this bug is useless now, forget about it.