Summary:ASTERISK-00867: [patch] Print warning on unknown option in sip.conf
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2004-01-17 17:20:33.000-0600Date Closed:2011-06-07 14:10:15
Versions:Frequency of
Environment:Attachments:( 0) 20040117__chan_sip_unknown_option.diff.txt
Description:As requested by Olle on the mailing list, reinvite=foo is not a valid option in sip.conf.  This will make sip.conf print warnings on unknown options, prompting users to fix their configs.  Will probably help a lot of people with typos.
Comments:By: zoa (zoa) 2004-01-17 17:24:16.000-0600

great stuff!

I'd like one for the other config files too ;)

By: Olle Johansson (oej) 2004-01-18 01:46:51.000-0600

I've played around with a similar thing. The "reinvite" match is ok, but the general warning needs to be implemented in both the general, the user and the peer option parsing routine.

And when defining a friend, both the user and the peer parsing routine is called. Then you'll get a lot of faulty warnings.

So for now, I suggest we only implement the "reinvite" match and do it in all places, build_user(), build_peer() and reload_config().

Then we need to document which options in the user/peer/friend section of sip.conf that applies to both, only users or only to peers and do error reporting like "Option yyyy applies only to peers and friends" or "Option xxx applies only to users and friends" as well as "Unknown option yyy, please read the documentation."

Thank you for providing the patch!