|Summary:||ASTERISK-00861: [patch] app_festival tweaks for answer and lost sound|
|Date Opened:||2004-01-17 11:35:20.000-0600||Date Closed:||2004-09-25 02:18:19|
|Environment:||Attachments:||( 0) festival2.diff|
|Description:||Unlike "playback" and other apps, app_festival does not answer the channel if it has not already been answered - seems a bit inconsistent and is fixed with this patch.|
App_festival also clips the start of the speech. Specifically, the text is converted correctly by Festival which returns a sound file with the speech starting immediately. Unfortunately, about the first second is lost when this is sent to a phone - presumably this is caused by phones synching to the incoming sound stream. The second part of the patch forces some silence to the phones before the Festival speech is sent.
|Comments:||By: zoa (zoa) 2004-01-17 17:22:27.000-0600|
I suppose only the first part of the patch should get to cvs ?
By: iain (iain) 2004-01-17 17:37:28.000-0600
Well, I'm not sure. The first part is straightforward and I think could go straight to CVS.
Someone else has complained about the clipping of speech. I think that a more fundamental re-write of app_festival is needed to sort out the writing of the speech file to a channel. I admit that what I have done is a very quick fix - but it may solve some problems and should be pretty inocuous. You could try putting it in CVS and back it out if it causes problems.
By: Brian West (bkw918) 2004-01-17 18:34:21.000-0600
fix the formating where the tabs match the rest of the code and its good to go.
By: iain (iain) 2004-01-18 11:33:43.000-0600
I think this has the tabs sorted ...
By: Brian West (bkw918) 2004-01-18 20:12:13.000-0600
Have you sent in a disclaimer? if not visit the main page of bugs.digium.com and pick one of the two and fax it in.
By: Brian West (bkw918) 2004-01-18 20:12:56.000-0600
Also these changes should be a config option?!?!
By: iain (iain) 2004-01-19 10:36:52.000-0600
You have a short form disclaimer on file for me.
I'm not sure about making this stuff a config option - it just seems more like a tweak/fix to me.
By: rainer (rainer) 2004-03-03 07:52:40.000-0600
I've tested this patch because I also noticed the skipping of the first second of a sentence when using festival. But even with the forced silence at the beginning, the first word is still skipped. Having the following values changed
memset( pad, 0, 8000);
write(fd, pad, 8000);
to 16000 it seems to work fine here.
By: Mark Spencer (markster) 2004-04-15 22:49:21
Fixed in CVS (just the first part)