| Summary: | ASTERISK-00783: [request + patch] Dial - Announce - Stop MOH after playing | ||
| Reporter: | kbock (kbock) | Labels: | |
| Date Opened: | 2004-01-11 14:25:14.000-0600 | Date Closed: | 2008-01-15 14:59:59.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 789.txt ( 1) bug789-afterannc.diff.txt ( 2) bug789-mohafterannc.diff.txt | |
| Description: | It would be nice if Dial would only stop MOH after the announcement has played -- otherwise the callee is sitting there with no audio. :-/ ****** ADDITIONAL INFORMATION ****** I wouldn't really call myself a coder at all, only very very very basic C. I've tried moving things around, but I get an audio error if I put it after ast_waitstream. I have no idea how to fix that. Any coders with the same thoughts would be appreciated. | ||
| Comments: | By: Olle Johansson (oej) 2004-03-21 08:49:57.000-0600 Is this still a problem with recent CVS? By: kbock (kbock) 2004-03-27 00:37:39.000-0600 Here's the patch to make this work, I hope. Please let me know if it breaks something else. If it does, I probably won't be able to fix this. I only reordered how things are in app_dial.c regarding the starting/stopping of MOH and announce to match like it is in app_queue.c By: kbock (kbock) 2004-03-27 00:54:27.000-0600 Yes, this is a problem with a recent CVS. My patch is based on the CVS I just pulled. By: twisted (twisted) 2004-04-29 09:19:03 Is this still an issue? Haven't seen an update in little over a month.. By: Mark Spencer (markster) 2004-04-29 09:50:53 Why does this change the sentringing/ast_indicate of 0? By: sbingner (sbingner) 2004-05-01 20:46:04 it look slike this breaks regular ringing, I'm going to redo it a bit... By: sbingner (sbingner) 2004-05-01 21:30:34 bug789-afterannc.diff.txt changes it to handle both the r and m option by starting it before calling wait_for_answer and stopping it just before returning from dial_exec. This seems to work right for me, I tested it with r,m and no options to dial. By: kbock (kbock) 2004-05-08 01:33:20 Cool, thanks for your help. It seems to work properly now. I'll test it further. By: Mark Spencer (markster) 2004-05-09 10:41:13 Any more updates on the further testing. I'm eager to merge this in when you guys are confident of it. By: Mark Spencer (markster) 2004-06-21 14:42:45 Updated and applied to CVS head By: Digium Subversion (svnbot) 2008-01-15 14:59:59.000-0600 Repository: asterisk Revision: 3262 U trunk/apps/app_dial.c ------------------------------------------------------------------------ r3262 | markster | 2008-01-15 14:59:59 -0600 (Tue, 15 Jan 2008) | 2 lines Don't stop moh until after announcement finishes (bug ASTERISK-783) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3262 | ||